Add support for server templates - #35
Merged
Merged
Conversation
zippolyte
previously requested changes
Nov 28, 2019
zippolyte
left a comment
Contributor
There was a problem hiding this comment.
One small comment about naming
LGTM otherwise, I'm still having trouble picturing how this would look like for the user
Contributor
Author
@zippolyte It isn't still possible to do it nicely. This only brings the Go code closer to Ruby/PHP/Python. configuration = datadog.NewConfiguration()
configuration.BaseUrl = configuration.ServerUrl(0, map[string]string{"site": "datadoghq.eu}) |
jirikuncar
dismissed
zippolyte’s stale review
November 28, 2019 11:07
The site config has been updated
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jirikuncar
force-pushed
the
jirikuncar/region
branch
from
November 28, 2019 19:10
a162548 to
a2016b2
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
approved these changes
Nov 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see also OpenAPITools/openapi-generator#4635