Skip to content

Move golden file and hard jar numbers to metadata#11740

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/move-golden-file-to-metadata
Jun 25, 2026
Merged

Move golden file and hard jar numbers to metadata#11740
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/move-golden-file-to-metadata

Conversation

@bric3

@bric3 bric3 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

The following PRs expanded the checks on the agent jar

Following some feedback the PR reads now reads some values to check from metadata/agent-jar-checks.properties

Motivation

Additional Notes

Removed the shift left groovy operators by method calls.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@bric3
bric3 requested review from PerfectSlayer and mhlidd June 25, 2026 09:51
@bric3 bric3 added type: feature Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 25, 2026
@bric3
bric3 marked this pull request as ready for review June 25, 2026 09:51
@bric3
bric3 requested review from a team as code owners June 25, 2026 09:51
@bric3
bric3 force-pushed the bdu/move-golden-file-to-metadata branch from b09e9ed to 6d95e60 Compare June 25, 2026 09:53

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Thanks for the follow up changes! It's nice to have all the expectations in one place 👍

@dd-octo-sts

dd-octo-sts Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.94 s 13.88 s [-0.3%; +1.1%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 12.98 s [-1.2%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.88 s 16.71 s [+0.0%; +1.9%] (maybe worse)
startup:petclinic:iast:Agent 16.89 s 16.92 s [-0.9%; +0.6%] (no difference)
startup:petclinic:profiling:Agent 16.89 s 16.85 s [-0.9%; +1.3%] (no difference)
startup:petclinic:sca:Agent 16.89 s 16.21 s [-0.4%; +8.9%] (no difference)
startup:petclinic:tracing:Agent 15.96 s 16.01 s [-1.4%; +0.7%] (no difference)

Commit: 6d95e60d · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 4e31214 into master Jun 25, 2026
582 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/move-golden-file-to-metadata branch June 25, 2026 12:21
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 25, 2026
TophrC-dd pushed a commit that referenced this pull request Jun 29, 2026
chore: Move golden file and hard jar numbers to metadata

Co-authored-by: brice.dutheil <brice.dutheil@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants