Move golden file and hard jar numbers to metadata#11740
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJun 25, 2026
Conversation
bric3
marked this pull request as ready for review
June 25, 2026 09:51
bric3
force-pushed
the
bdu/move-golden-file-to-metadata
branch
from
June 25, 2026 09:53
b09e9ed to
6d95e60
Compare
PerfectSlayer
approved these changes
Jun 25, 2026
PerfectSlayer
left a comment
Contributor
There was a problem hiding this comment.
👏 praise: Thanks for the follow up changes! It's nice to have all the expectations in one place 👍
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
bdu/move-golden-file-to-metadata
branch
June 25, 2026 12:21
TophrC-dd
pushed a commit
that referenced
this pull request
Jun 29, 2026
chore: Move golden file and hard jar numbers to metadata Co-authored-by: brice.dutheil <brice.dutheil@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
The following PRs expanded the checks on the agent jar
Following some feedback the PR reads now reads some values to check from
metadata/agent-jar-checks.propertiesMotivation
Additional Notes
Removed the shift left groovy operators by method calls.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]