Skip to content

Cover decoded trace sampling priority. #11773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Jun 29, 2026
Merged

Cover decoded trace sampling priority. #11773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils/test-agent-utils/decoder/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ plugins {

apply(from = "$rootDir/gradle/java.gradle")

extra["minimumInstructionCoverage"] = 0.8
extra["excludedClassesCoverage"] = listOf(
"datadog.trace.test.agent.decoder.v04.raw.*",
"datadog.trace.test.agent.decoder.v05.raw.*",
"datadog.trace.test.agent.decoder.v1.raw.*",
)

dependencies {
Expand Down
4 changes: 4 additions & 0 deletions .../test-agent-utils/decoder/src/test/java/datadog/trace/test/agent/decoder/DecoderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import static java.util.Collections.singletonMap;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertIterableEquals;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.io.File;
Expand All @@ -24,6 +25,7 @@ public void decodeV05() throws Throwable {
DecodedMessage message = Decoder.decodeV05(buffer);
List<DecodedTrace> traces = message.getTraces();
assertEquals(1, traces.size());
assertNull(traces.get(0).getSamplingPriority());
List<DecodedSpan> spans = traces.get(0).getSpans();
assertEquals(2, spans.size());
List<DecodedSpan> sorted = Decoder.sortByStart(spans);
Expand Down Expand Up @@ -59,6 +61,7 @@ public void decodeV04() throws Throwable {
DecodedMessage message = Decoder.decodeV04(buffer);
List<DecodedTrace> traces = message.getTraces();
assertEquals(1, traces.size());
assertNull(traces.get(0).getSamplingPriority());
List<DecodedSpan> spans = traces.get(0).getSpans();
assertEquals(2, spans.size());
List<DecodedSpan> sorted = Decoder.sortByStart(spans);
Expand Down Expand Up @@ -96,6 +99,7 @@ public void decodeV1() throws Throwable {
DecodedMessage message = Decoder.decodeV1(buffer);
List<DecodedTrace> traces = message.getTraces();
assertEquals(1, traces.size());
assertEquals(1, traces.get(0).getSamplingPriority());
Comment thread
AlexeyKuznetsov-DD marked this conversation as resolved.
List<DecodedSpan> spans = traces.get(0).getSpans();
assertEquals(2, spans.size());
List<DecodedSpan> sorted = Decoder.sortByStart(spans);
Expand Down
Loading