Skip to content

Remove unneded akka/pekko exclusion#11952

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/akak
Jul 15, 2026
Merged

Remove unneded akka/pekko exclusion#11952
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
andrea.marziali/akak

Conversation

@amarziali

Copy link
Copy Markdown
Contributor

What Does This Do

akka.dispatch.MailBox or the pekko equivalent was excluded Runnables with no effect because of a typo (MailBox instead of Mailbox. This PR removes that since not needed

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali
amarziali requested a review from a team as a code owner July 15, 2026 06:28
@amarziali amarziali added the type: bug fix Bug fix label Jul 15, 2026
@amarziali
amarziali requested review from jordan-wong and removed request for a team July 15, 2026 06:28
@amarziali amarziali added the inst: akka Akka instrumentation label Jul 15, 2026
@amarziali
amarziali requested a review from mcculls July 15, 2026 06:28

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

PR removes dead-code exclusion filters that never worked due to a typo: code tried to exclude MailBox (capital B) but the actual class is Mailbox (lowercase b). Zero behavioral impact since the exclusion never matched anything. All unused imports cleanly removed. This is safe refactoring that simplifies the codebase.

Was this helpful? React 👍 or 👎

📊 Validated against 1 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 20a1e1c · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-6

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 13.90 s [-0.0%; +1.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.90 s 12.93 s [-1.1%; +0.6%] (no difference)
startup:petclinic:appsec:Agent 16.90 s 16.79 s [-0.4%; +1.7%] (no difference)
startup:petclinic:iast:Agent 16.88 s 17.00 s [-1.5%; +0.2%] (no difference)
startup:petclinic:profiling:Agent 16.68 s 16.85 s [-2.2%; +0.1%] (no difference)
startup:petclinic:sca:Agent 16.27 s 16.76 s [-7.4%; +1.5%] (no difference)
startup:petclinic:tracing:Agent 16.12 s 16.13 s [-0.8%; +0.7%] (no difference)

Commit: 20a1e1ce · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@amarziali amarziali added type: bug fix Bug fix and removed type: bug fix Bug fix labels Jul 15, 2026
@amarziali amarziali changed the title Remove unneded akka/pekko exlcusion Remove unneded akka/pekko exclusion Jul 15, 2026

@mcculls mcculls left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find - worth double-checking with @bantonsson in case there was a non-functional reason for the original exclusion which would still be worthwhile after the typo fix.

@amarziali

Copy link
Copy Markdown
Contributor Author

Good find - worth double-checking with @bantonsson in case there was a non-functional reason for the original exclusion which would still be worthwhile after the typo fix.

Yes makes sense. I initially just fixed the typo and I noticed that the tests were no more passing (i.e. not tracing). So I only did the easy path (keep as today but remove the code). I'll double check with Bjorn so

@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 15, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-15 09:51:19 UTC ℹ️ Start processing command /merge


2026-07-15 09:51:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-15 11:52:04 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 7194664154496256273 took longer than expected. The current limit for the base branch 'master' is 120 minutes.

Possible reasons:

  • some mandatory checkruns are failing:
    • Check pull request labels
    • Check pull requests
    • Enforce Groovy migration

@amarziali

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 15, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-15 11:58:47 UTC ℹ️ Start processing command /merge


2026-07-15 11:58:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 2h (p90).


2026-07-15 13:33:20 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 1918d9f into master Jul 15, 2026
593 of 598 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the andrea.marziali/akak branch July 15, 2026 13:33
@github-actions github-actions Bot added this to the 1.65.0 milestone Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inst: akka Akka instrumentation type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants