Remove unneded akka/pekko exclusion#11952
Conversation
There was a problem hiding this comment.
More details
PR removes dead-code exclusion filters that never worked due to a typo: code tried to exclude MailBox (capital B) but the actual class is Mailbox (lowercase b). Zero behavioral impact since the exclusion never matched anything. All unused imports cleanly removed. This is safe refactoring that simplifies the codebase.
📊 Validated against 1 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 20a1e1c · What is Autotest? · Any feedback? Reach out in #autotest
This comment has been minimized.
This comment has been minimized.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
mcculls
left a comment
There was a problem hiding this comment.
Good find - worth double-checking with @bantonsson in case there was a non-functional reason for the original exclusion which would still be worthwhile after the typo fix.
Yes makes sense. I initially just fixed the typo and I noticed that the tests were no more passing (i.e. not tracing). So I only did the easy path (keep as today but remove the code). I'll double check with Bjorn so |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 7194664154496256273 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
1918d9f
into
master
What Does This Do
akka.dispatch.MailBoxor the pekko equivalent was excluded Runnables with no effect because of a typo (MailBoxinstead ofMailbox. This PR removes that since not neededMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]