Bump spotless to latest version 8.1.0#9881
Conversation
…internal-api Also this forces JDK 11 to be the minimum.
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java # utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060778
Total [baseline] (10.872 s) : 0, 10871856
Agent [candidate] (1.059 s) : 0, 1059136
Total [candidate] (10.747 s) : 0, 10746621
section appsec
Agent [baseline] (1.243 s) : 0, 1243334
Total [baseline] (10.943 s) : 0, 10943060
Agent [candidate] (1.228 s) : 0, 1227602
Total [candidate] (10.92 s) : 0, 10920461
section iast
Agent [baseline] (1.193 s) : 0, 1192677
Total [baseline] (11.218 s) : 0, 11217990
Agent [candidate] (1.203 s) : 0, 1203412
Total [candidate] (11.139 s) : 0, 11139289
section profiling
Agent [baseline] (1.199 s) : 0, 1199410
Total [baseline] (10.888 s) : 0, 10888055
Agent [candidate] (1.207 s) : 0, 1207481
Total [candidate] (10.945 s) : 0, 10944638
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.517 ms) : 0, 1517
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (713.27 ms) : 0, 713270
BytebuddyAgent [candidate] (710.936 ms) : 0, 710936
GlobalTracer [baseline] (251.128 ms) : 0, 251128
GlobalTracer [candidate] (251.335 ms) : 0, 251335
AppSec [baseline] (32.374 ms) : 0, 32374
AppSec [candidate] (32.595 ms) : 0, 32595
Debugger [baseline] (6.445 ms) : 0, 6445
Debugger [candidate] (6.508 ms) : 0, 6508
Remote Config [baseline] (682.195 µs) : 0, 682
Remote Config [candidate] (691.583 µs) : 0, 692
Telemetry [baseline] (16.177 ms) : 0, 16177
Telemetry [candidate] (15.797 ms) : 0, 15797
Flare Poller [baseline] (4.132 ms) : 0, 4132
Flare Poller [candidate] (4.884 ms) : 0, 4884
section appsec
crashtracking [baseline] (1.511 ms) : 0, 1511
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (742.032 ms) : 0, 742032
BytebuddyAgent [candidate] (731.422 ms) : 0, 731422
GlobalTracer [baseline] (244.185 ms) : 0, 244185
GlobalTracer [candidate] (240.953 ms) : 0, 240953
IAST [baseline] (25.093 ms) : 0, 25093
IAST [candidate] (24.788 ms) : 0, 24788
AppSec [baseline] (176.137 ms) : 0, 176137
AppSec [candidate] (174.929 ms) : 0, 174929
Debugger [baseline] (6.296 ms) : 0, 6296
Debugger [candidate] (6.29 ms) : 0, 6290
Remote Config [baseline] (686.381 µs) : 0, 686
Remote Config [candidate] (682.129 µs) : 0, 682
Telemetry [baseline] (8.083 ms) : 0, 8083
Telemetry [candidate] (8.158 ms) : 0, 8158
Flare Poller [baseline] (3.983 ms) : 0, 3983
Flare Poller [candidate] (3.912 ms) : 0, 3912
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.512 ms) : 0, 1512
BytebuddyAgent [baseline] (831.925 ms) : 0, 831925
BytebuddyAgent [candidate] (839.758 ms) : 0, 839758
GlobalTracer [baseline] (237.851 ms) : 0, 237851
GlobalTracer [candidate] (239.25 ms) : 0, 239250
IAST [baseline] (33.463 ms) : 0, 33463
IAST [candidate] (31.146 ms) : 0, 31146
AppSec [baseline] (27.804 ms) : 0, 27804
AppSec [candidate] (30.761 ms) : 0, 30761
Debugger [baseline] (6.059 ms) : 0, 6059
Debugger [candidate] (6.104 ms) : 0, 6104
Remote Config [baseline] (611.642 µs) : 0, 612
Remote Config [candidate] (623.32 µs) : 0, 623
Telemetry [baseline] (7.869 ms) : 0, 7869
Telemetry [candidate] (8.145 ms) : 0, 8145
Flare Poller [baseline] (10.686 ms) : 0, 10686
Flare Poller [candidate] (11.059 ms) : 0, 11059
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (735.062 ms) : 0, 735062
BytebuddyAgent [candidate] (740.003 ms) : 0, 740003
GlobalTracer [baseline] (222.256 ms) : 0, 222256
GlobalTracer [candidate] (223.988 ms) : 0, 223988
AppSec [baseline] (32.112 ms) : 0, 32112
AppSec [candidate] (32.54 ms) : 0, 32540
Debugger [baseline] (6.896 ms) : 0, 6896
Debugger [candidate] (7.713 ms) : 0, 7713
Remote Config [baseline] (683.677 µs) : 0, 684
Remote Config [candidate] (684.994 µs) : 0, 685
Telemetry [baseline] (16.602 ms) : 0, 16602
Telemetry [candidate] (15.617 ms) : 0, 15617
Flare Poller [baseline] (4.172 ms) : 0, 4172
Flare Poller [candidate] (4.222 ms) : 0, 4222
ProfilingAgent [baseline] (110.864 ms) : 0, 110864
ProfilingAgent [candidate] (111.274 ms) : 0, 111274
Profiling [baseline] (111.486 ms) : 0, 111486
Profiling [candidate] (111.923 ms) : 0, 111923
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1070736
Total [baseline] (8.731 s) : 0, 8730646
Agent [candidate] (1.054 s) : 0, 1054383
Total [candidate] (8.724 s) : 0, 8723753
section iast
Agent [baseline] (1.197 s) : 0, 1197186
Total [baseline] (9.36 s) : 0, 9359638
Agent [candidate] (1.192 s) : 0, 1191815
Total [candidate] (9.3 s) : 0, 9300429
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.527 ms) : 0, 1527
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (723.374 ms) : 0, 723374
BytebuddyAgent [candidate] (709.154 ms) : 0, 709154
GlobalTracer [baseline] (250.55 ms) : 0, 250550
GlobalTracer [candidate] (249.394 ms) : 0, 249394
AppSec [baseline] (32.293 ms) : 0, 32293
AppSec [candidate] (32.07 ms) : 0, 32070
Debugger [baseline] (6.477 ms) : 0, 6477
Debugger [candidate] (6.43 ms) : 0, 6430
Remote Config [baseline] (697.933 µs) : 0, 698
Remote Config [candidate] (687.394 µs) : 0, 687
Telemetry [baseline] (16.347 ms) : 0, 16347
Telemetry [candidate] (16.293 ms) : 0, 16293
Flare Poller [baseline] (4.148 ms) : 0, 4148
Flare Poller [candidate] (4.012 ms) : 0, 4012
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.492 ms) : 0, 1492
BytebuddyAgent [baseline] (835.334 ms) : 0, 835334
BytebuddyAgent [candidate] (831.609 ms) : 0, 831609
GlobalTracer [baseline] (238.239 ms) : 0, 238239
GlobalTracer [candidate] (237.538 ms) : 0, 237538
IAST [baseline] (32.907 ms) : 0, 32907
IAST [candidate] (33.147 ms) : 0, 33147
AppSec [baseline] (28.895 ms) : 0, 28895
AppSec [candidate] (27.871 ms) : 0, 27871
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.063 ms) : 0, 6063
Remote Config [baseline] (616.863 µs) : 0, 617
Remote Config [candidate] (609.669 µs) : 0, 610
Telemetry [baseline] (7.894 ms) : 0, 7894
Telemetry [candidate] (7.853 ms) : 0, 7853
Flare Poller [baseline] (10.734 ms) : 0, 10734
Flare Poller [candidate] (10.794 ms) : 0, 10794
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section baseline
no_agent (19.149 ms) : 18950, 19347
. : milestone, 19149,
appsec (19.73 ms) : 19531, 19928
. : milestone, 19730,
code_origins (17.773 ms) : 17596, 17949
. : milestone, 17773,
iast (17.797 ms) : 17618, 17975
. : milestone, 17797,
profiling (18.402 ms) : 18219, 18585
. : milestone, 18402,
tracing (17.566 ms) : 17390, 17743
. : milestone, 17566,
section candidate
no_agent (19.122 ms) : 18922, 19321
. : milestone, 19122,
appsec (18.515 ms) : 18324, 18706
. : milestone, 18515,
code_origins (17.78 ms) : 17603, 17958
. : milestone, 17780,
iast (17.809 ms) : 17635, 17983
. : milestone, 17809,
profiling (18.43 ms) : 18244, 18616
. : milestone, 18430,
tracing (17.569 ms) : 17395, 17743
. : milestone, 17569,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.212 ms) : 1200, 1224
. : milestone, 1212,
iast (3.175 ms) : 3128, 3222
. : milestone, 3175,
iast_FULL (5.653 ms) : 5596, 5709
. : milestone, 5653,
iast_GLOBAL (3.455 ms) : 3409, 3502
. : milestone, 3455,
profiling (1.927 ms) : 1911, 1943
. : milestone, 1927,
tracing (1.764 ms) : 1749, 1779
. : milestone, 1764,
section candidate
no_agent (1.202 ms) : 1190, 1213
. : milestone, 1202,
iast (3.271 ms) : 3227, 3316
. : milestone, 3271,
iast_FULL (5.839 ms) : 5781, 5898
. : milestone, 5839,
iast_GLOBAL (3.551 ms) : 3497, 3605
. : milestone, 3551,
profiling (2.081 ms) : 2063, 2100
. : milestone, 2081,
tracing (1.755 ms) : 1741, 1769
. : milestone, 1755,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.456 ms) : 2405, 2508
. : milestone, 2456,
iast (2.211 ms) : 2147, 2275
. : milestone, 2211,
iast_GLOBAL (2.252 ms) : 2187, 2317
. : milestone, 2252,
profiling (2.079 ms) : 2025, 2133
. : milestone, 2079,
tracing (2.039 ms) : 1988, 2090
. : milestone, 2039,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (2.444 ms) : 2393, 2496
. : milestone, 2444,
iast (2.204 ms) : 2139, 2268
. : milestone, 2204,
iast_GLOBAL (2.25 ms) : 2185, 2315
. : milestone, 2250,
profiling (2.044 ms) : 1992, 2096
. : milestone, 2044,
tracing (2.031 ms) : 1981, 2082
. : milestone, 2031,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~cbb7615c95, baseline=1.57.0-SNAPSHOT~53f913f9bcb
dateFormat X
axisFormat %s
section baseline
no_agent (15.703 s) : 15703000, 15703000
. : milestone, 15703000,
appsec (14.871 s) : 14871000, 14871000
. : milestone, 14871000,
iast (18.409 s) : 18409000, 18409000
. : milestone, 18409000,
iast_GLOBAL (17.953 s) : 17953000, 17953000
. : milestone, 17953000,
profiling (15.17 s) : 15170000, 15170000
. : milestone, 15170000,
tracing (14.697 s) : 14697000, 14697000
. : milestone, 14697000,
section candidate
no_agent (15.719 s) : 15719000, 15719000
. : milestone, 15719000,
appsec (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
iast (18.277 s) : 18277000, 18277000
. : milestone, 18277000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (14.498 s) : 14498000, 14498000
. : milestone, 14498000,
tracing (14.631 s) : 14631000, 14631000
. : milestone, 14631000,
|
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(8) | ||
| } |
There was a problem hiding this comment.
praise: In my opinion this can go in a separate PR.
There was a problem hiding this comment.
I think we can keep it here, as it related to spotless bump anyway...
Probably it can be part of PR where we would migrate to JDK 21.
| version = 3.8.6 | ||
| runner.dialect = scala213 |
There was a problem hiding this comment.
note: May need a comment (can be done in a follow-up PR), and maybe referring to gradle/spotless.gradle
| ktlint('1.8.0').editorConfigOverride([ | ||
| // Disable trailing comma rules to minimize diff. | ||
| 'ktlint_standard_trailing-comma-on-call-site': 'disabled', | ||
| 'ktlint_standard_trailing-comma-on-declaration-site': 'disabled' | ||
| ]) |
There was a problem hiding this comment.
note: FYI ktlint has its own ruleset that deviate from "standard" kotlin style. It's good for this PR, but I suggest we use the same approach as with dd-trce-java-native that tells ktlint to use the official Kotlin rules (named after intellij).
What Does This Do
Updated spotless and formatters to latest versions.
Motivation
To ensure the project uses the latest tooling and maintains consistent, up-to-date code formatting.
Additional Notes
Requires Java 21.