This repository was archived by the owner on Mar 25, 2024. It is now read-only.
Add backwards compatibility for dashboard template variable format#93
Merged
Conversation
Contributor
|
You can avoid the code duplication by creating a function that does the parsing and passing that function into the type parameter of the add_argument calls (https://github.com/DataDog/dogapi/blob/update_templating/src/dogshell/dashboard.py#L28 and https://github.com/DataDog/dogapi/blob/update_templating/src/dogshell/dashboard.py#L37) That way, argparse will convert the command line params into the right form. Also, does the server api know how to handle both data types? The comma-separated one will be a list of lists, while the json one will be a list of dicts. |
Contributor
Author
|
Thanks @clofresh! The server API handles both data types. I'll make the change you suggested and merge. |
wang-arthur
pushed a commit
that referenced
this pull request
May 30, 2014
Add backwards compatibility for dashboard template variable format
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes template variables in dogshell backwards compatible (the API itself was already backwards compatible)