feat(parameters): validate bounds and add brightness/contrast - #59
Merged
Conversation
Add unconditional numeric bounds and contextual validation while preserving signed coordinates and descending domains. Assisted-by: GPT-5.6 Sol
This was referenced Sep 10, 2026
Contributor
Author
|
CI tests are failing only because this PR needs the changes implemented in this guidata PR. |
PierreRaybaut
marked this pull request as ready for review
September 10, 2026 07:34
ThomasMalletCodra
self-requested a review
September 10, 2026 12:52
The `getattr(super(), "validate_parameters", None)` guard was duplicated verbatim across five parameter classes. `validate_dataset()` already performs exactly that lookup, so it now documents and accepts a `super()` proxy and becomes the single place resolving the optional parent hook. Behaviour is unchanged: `super()` still resolves against the caller's MRO bound to `self`, and cooperative chains still terminate silently when no ancestor defines the hook. Verified on the multiple-inheritance case (`UniformDistribution2DParam`), which is why a plain helper call was kept instead of introducing a mixin that would have altered MRO linearization. Side effect: five `not-callable` false positives disappear, the dynamic lookup no longer being visible to Pylint at each call site. Replace the scattered `no-value-for-parameter` suppressions with a documented module-level disable in the three test modules exercising the expanded-keyword call style, which `@computation_function` enables by rewriting the signature at import time -- something Pylint cannot follow. Resync the translation catalogs, which were out of date on this branch: the brightness/contrast strings had been appended manually instead of scanned, and the `sigima.objects.annotations` doc entries were missing. Assisted-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration
Depends on PlotPyStack/guidata#114 for
HistogramRangeItemand the slider-enabled editing primitives.Downstream PR: DataLab-Platform/DataLab#368.
Before merge
HistogramRangeItem.Validation
Focused validation and exposure tests: 148 passed, 4 skipped.