Bug-98: storeObject Failed Junit Test#99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After further investigation, it appears that a bug was introduced when optimizing how the default hash algorithms were calculated.
The junit test did its job and threw a new unexpected exception
PidRefsFileExistsException: which is thrown when thepidthat has already been accounted for is referencing anothercid.This can be observed where multiple instances of unexpected hash calculations were produced, for example:
This specific junit test should only encounter two types of exceptions:
RunTimeExceptionwhich is thrown when thepidis already being stored (synchronization rejects)HashStoreRefsAlreadyExistExceptionwhich is thrown when everything is already tagged as expected.For now, we will roll back the changes specifically made related to setting up of the default message digest objects/hash algorithms to calculate. A new issue will be created when time permitting to refactor/optimize the affected code.