[codex] Remove realtime initial state startup gate#166
Merged
Conversation
commit: |
AdirAmsalem
approved these changes
Jun 18, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0136351. Configure here.
…neration Replace the per-run Set + threaded run id with a single generation counter bumped in tearDown(). Every cancel site already called tearDown(), so the explicit cancels and the Set were redundant. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Why
The backend now owns drop-until-initial-state behavior, so the SDK no longer needs to block connection readiness on the initial prompt/image ack. This lets clients publish immediately and realize the time-to-first-frame improvement while still reporting ack failures.
Verification
pnpm typecheckpnpm testpnpm buildpnpm test:e2e:realtimewas not run locally becauseDECART_API_KEYis not set in this environment.Note
Medium Risk
Changes realtime connect semantics (earlier connected state and track publish; ack failures no longer fail connect or trigger retry), which affects all SDK consumers of stream sessions.
Overview
Removes the client-side
InitialStateGateand stops blockingconnect()on the initial prompt/image WebSocket ack. After room join, the session proceeds through LiveKit connect and immediate local track publish, then marks connected—matching backend-owned drop-until-initial-state behavior for faster time-to-first-frame.Initial-state ack failures are handled asynchronously via
watchInitialStateAck, which emits the existingerrorevent without tearing down or retrying startup.teardownGenerationprevents stale ack rejections from surfacing as errors when a connect retry tears down a pending handshake.Unit tests drop gate-specific coverage and assert the new startup order, async ack errors, and no spurious errors when retry teardown invalidates a pending ack.
Reviewed by Cursor Bugbot for commit de3ca18. Bugbot is set up for automated code reviews on this repo. Configure here.