Skip to content

Validate HTTP/2 header casing and lowercase default user-agent #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincenthawke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate HTTP/2 header casing and lowercase default user-agent #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ const DEFAULT_OPTIONS: TlsClientDefaultOptions = {
'accept-datetime',
],
defaultHeaders: {
'User-Agent':
'user-agent':
Comment thread
coderabbitai[bot] marked this conversation as resolved.
'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/146.0.0.0 Safari/537.36',
},
connectHeaders: null,
Expand Down Expand Up @@ -562,6 +562,15 @@ export class SessionClient {
throw new Error('ModuleClient must be an instance of ModuleClient');
}

const allHeaders = [...Object.keys(options.defaultHeaders ?? {}), ...Object.keys(options.connectHeaders ?? {})]
if (options.forceHttp1 !== true) {
for (const header of allHeaders) {
if (header !== header.toLowerCase()) {
throw new Error(`HTTP/2 header must be lowercase for fingerprint consistency: ${header}`);
}
}
}

Comment thread
coderabbitai[bot] marked this conversation as resolved.
// Copy nested mutables so one session's edits never bleed into another
this.defaultOptions = {
...DEFAULT_OPTIONS,
Expand Down