fix: prevent Invalid URL error in prepareBaseUrl for http/https baseUrl - #8434
Closed
yasinkocak wants to merge 4 commits into
Closed
fix: prevent Invalid URL error in prepareBaseUrl for http/https baseUrl#8434yasinkocak wants to merge 4 commits into
yasinkocak wants to merge 4 commits into
Conversation
yasinkocak
had a problem deploying
to
authentication
August 19, 2025 13:30 — with 
GitHub Actions
Failure
|
Thank you for your contribution to TestCafe. When a member of the TestCafe team becomes available, they will review this PR. |
yasinkocak
had a problem deploying
to
authentication
August 28, 2025 09:16 — with
GitHub Actions
Failure
yasinkocak
had a problem deploying
to
authentication
September 18, 2025 13:35 — with
GitHub Actions
Failure
yasinkocak
had a problem deploying
to
authentication
October 1, 2025 14:42 — with
GitHub Actions
Failure
2 tasks
Bayheck
added a commit
that referenced
this pull request
Dec 29, 2025
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> ## Purpose _Describe the problem you want to address or the feature you want to implement._ ## Approach _Describe how your changes address the issue or implement the desired functionality in as much detail as possible._ ## References closes #8434 closes #8364 ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail --------- Co-authored-by: adil.rakhaliyev <adil.rakhaliyev@devexpress.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an
Invalid URLerror that occurs when usingbaseUrlwithhttporhttpsvalues in TestCafe 3.7.1+ on Node.js 20.18+.Current behavior
The current implementation of
prepareBaseUrlappliespath.jointo the providedbaseUrl.For web URLs, this produces invalid results:
new URL("http:/devexpress.github.io/")→ throwsTypeError: Invalid URLThis breaks
.page(...)and config-basedbaseUrlwhen using standard web URLs.Expected behavior
baseUrlis always treated as a web URL if it starts withhttp://orhttps://.file://.How does this PR fix the problem?
http://andhttps://URLs (adds trailing slash if missing).file://URLs.pathToFileURL.Related issue
Fixes #8364