Design/#60 - ListView min/maxWidth 설정 및 상태 안내 문구 추가 - #67
Merged
Conversation
1 task
Walkthrough
Changes미리보기 및 화면 동작
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Projects/DVPresentation/Sources/Dependencies/SecretClient.swift`:
- Around line 35-51: Update fetchByQuery to apply query.searchText filtering to
the collection-specific filtered secrets before calling sorted, matching the
search predicate used by InMemorySecretQueryFilter.apply. Preserve the existing
collection selection and sorting behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6afea531-1e76-49b3-ab62-9be02d578744
📒 Files selected for processing (7)
Projects/DVDesign/Sources/Components/DVTitleBar.swiftProjects/DVPresentation/Resources/Localizable.xcstringsProjects/DVPresentation/Sources/Dependencies/SecretClient.swiftProjects/DVPresentation/Sources/Features/CreateSecret/CreateSecretFeature.swiftProjects/DVPresentation/Sources/Features/Main/MainView.swiftProjects/DVPresentation/Sources/Features/SecretList/SecretListView.swiftProjects/DVPresentation/Sources/Features/Sidebar/SidebarView.swift
Comment on lines
+35
to
+51
| fetchByQuery: { query in | ||
| let filtered: [Secret] | ||
| switch query.collection { | ||
| case .expired(let referenceDate): | ||
| filtered = [Secret].preview.filter { | ||
| $0.deletedAt == nil && ($0.expiresAt.map { $0 < referenceDate } ?? false) | ||
| } | ||
| case .deleted: | ||
| filtered = [Secret].preview.filter { $0.deletedAt != nil } | ||
| case .liked: | ||
| filtered = [Secret].preview.filter { $0.deletedAt == nil && $0.liked } | ||
| case .project(let id): | ||
| filtered = [Secret].preview(in: id) | ||
| case .all: | ||
| filtered = [Secret].preview.filter { $0.deletedAt == nil } | ||
| } | ||
| case .deleted: | ||
| return [Secret].preview.filter { $0.deletedAt != nil } | ||
| case .liked: | ||
| return [Secret].preview.filter { $0.deletedAt == nil && $0.liked } | ||
| case .project(let id): | ||
| return [Secret].preview(in: id) | ||
| case .all: | ||
| return [Secret].preview.filter { $0.deletedAt == nil } | ||
| } | ||
| }, | ||
| softDelete: { _ in .preview }, | ||
| restore: { _ in .preview }, | ||
| permanentlyDelete: { _ in }, | ||
| fetchProjects: { .preview }, | ||
| createProject: { name in | ||
| Project(id: UUID(), name: name, createdAt: .now, updatedAt: .now) | ||
| }, | ||
| linkProject: { _, _ in } | ||
| ) | ||
| return sorted(filtered, by: query.sort) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
미리보기 쿼리에 searchText 필터를 적용하세요.
fetchByQuery가 query.collection과 query.sort만 적용합니다. 따라서 미리보기에서 검색어를 변경해도 결과가 검색어와 무관하게 유지됩니다. 프로덕션의 InMemorySecretQueryFilter.apply와 동일한 검색 조건을 정렬 전에 적용하세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Projects/DVPresentation/Sources/Dependencies/SecretClient.swift` around lines
35 - 51, Update fetchByQuery to apply query.searchText filtering to the
collection-specific filtered secrets before calling sorted, matching the search
predicate used by InMemorySecretQueryFilter.apply. Preserve the existing
collection selection and sorting behavior.
doyeonk429
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What’s this PR?
📌 관련 이슈 (Related Issue)
🧶 주요 변경 내용 (Summary)
📸 스크린샷 (Optional)
🧪 테스트 / 검증 내역
💬 기타 공유 사항
🙇🏻♀️ 리뷰 가이드 (선택)
Summary by CodeRabbit
개선 사항
변경 사항