Skip to content

fix(dgw): derive internal realm from gateway id - #1621

Merged
Benoît Cortier (CBenoit) merged 2 commits into
dev/rdp-kerberos-credentials-injectionfrom
feat/kdc-realm-from-gateway-id
Dec 15, 2025
Merged

fix(dgw): derive internal realm from gateway id#1621
Benoît Cortier (CBenoit) merged 2 commits into
dev/rdp-kerberos-credentials-injectionfrom
feat/kdc-realm-from-gateway-id

Conversation

@TheBestTvarynka

@TheBestTvarynka Pavlo Myroniuk (TheBestTvarynka) commented Dec 12, 2025

Copy link
Copy Markdown
Collaborator

Hi,

This PR addresses this comment: #1605 (comment)

suggestion (non-blocking): Do not make this configurable. It would be much more convenient if this is automatically derived from the Devolutions Gateway ID (which can be changed dynamically using configuration pushing!). Can be addressed in a follow up PR.

Also, I replaced the kdc crate git link in Cargo.toml with a proper crate version.

@TheBestTvarynka Pavlo Myroniuk (TheBestTvarynka) changed the title feat(devolutions-gateway): derive realm from gateway id feat(devolutions-gateway): derive internal realm from gateway id Dec 12, 2025
@CBenoit Benoît Cortier (CBenoit) changed the title feat(devolutions-gateway): derive internal realm from gateway id fix(dgw): derive internal realm from gateway id Dec 15, 2025
CBenoit
Benoît Cortier (CBenoit) approved these changes Dec 15, 2025
View reviewed changes

@CBenoit Benoît Cortier (CBenoit) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBenoit
Benoît Cortier (CBenoit) merged commit 86c403e into dev/rdp-kerberos-credentials-injection Dec 15, 2025
40 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the feat/kdc-realm-from-gateway-id branch December 15, 2025 16:50
Merged
Pavlo Myroniuk (TheBestTvarynka) added a commit that referenced this pull request Dec 16, 2025
@TheBestTvarynka @PavloMyroniuk-apriorit
fix(dgw): derive internal realm from gateway id (#1621)
a00feb0
Pavlo Myroniuk (TheBestTvarynka) added a commit that referenced this pull request Dec 18, 2025
@TheBestTvarynka @PavloMyroniuk-apriorit
fix(dgw): derive internal realm from gateway id (#1621)
96b1085
Pavlo Myroniuk (TheBestTvarynka) pushed a commit that referenced this pull request Dec 18, 2025
@PavloMyroniuk-apriorit
fix(dgw): derive internal realm from gateway id (#1621)
67848b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CBenoit Benoît Cortier (CBenoit) CBenoit approved these changes

Assignees

@TheBestTvarynka Pavlo Myroniuk (TheBestTvarynka)

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheBestTvarynka @CBenoit @PavloMyroniuk-apriorit