Skip to content

fix: align release workflow pin assertions - #225

Open
dDevAhmed wants to merge 1 commit into
mainfrom
fix/release-workflow-pin-test
Open

dDevAhmed wants to merge 1 commit into
mainfrom
fix/release-workflow-pin-test

Conversation

@dDevAhmed

@dDevAhmed dDevAhmed commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Update the release-policy regression test to assert the Changesets Action v2.1.2 commit SHA merged by Dependabot in PR #223.

This restores the broken main test baseline without changing the release workflow, permissions, environment, or publication gate.

Related Issue

Post-merge regression repair; no contributor issue is closed.

Scope

  • update four expected immutable Changesets Action SHAs in tests/release-workflow.test.ts
  • no workflow or package changes
  • NPM_PUBLISH_ENABLED remains unchanged and publication remains disabled

Testing

  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm test — 155 passed, 1 Cargo-only validation skipped locally
  • npm run build
  • npm run release:dry-run

Security Impact

  • No security-sensitive behavior is changed

The test continues enforcing immutable SHA pins, single-job OIDC permission, and the protected npm-release environment.

Release Impact

  • No published/user-visible behavior change
  • Changeset not required; test-only repair

Documentation

  • No documentation change required

Summary by CodeRabbit

  • Tests
    • Updated release workflow tests to validate the current pinned Changesets action revision across release, versioning, packaging, and publishing scenarios.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: af097155-27b6-4270-a690-8e4e154b2160

📥 Commits

Reviewing files that changed from the base of the PR and between 7bd7e26 and 1f6e305.

📒 Files selected for processing (1)
  • tests/release-workflow.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow tests now expect the updated pinned Changesets action commit for select-mode, versioning, packing, and publishing.

Changes

Release workflow validation

Layer / File(s) Summary
Update release action pin
tests/release-workflow.test.ts
Four assertions now require commit ae32849d5ba541f9ae29e40e22a623bc13562f51 instead of the previous commit.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 1f6e3

This change only updates release-workflow test expectations to match the existing pinned action commit; release behavior and permissions are unchanged, so it is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: updating release workflow pin assertions to match the intended Changesets commit pin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@abla86 abla86 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abla86 abla86 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abla86 abla86 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants