Repository navigation
Wire insurance expiry checks into the daily alert run - #1557
Merged
yusuftomilola merged 1 commit intoSep 26, 2026
Merged
yusuftomilola merged 1 commit into
yusuftomilola merged 1 commit into
Conversation
ExpiryAlertsService only checked warranty and maintenance expiries, not insurance. Adds checkInsuranceExpiries(), called from the same daily cron run as the existing checks. Asset currently has no insuranceExpiry field (only warrantyExpiry), so this is a stub matching the existing checkWarrantyExpiries/ checkMaintenanceDue maturity level rather than a real query - flagged in a comment so the gap is visible once the field is added.
|
@demilade18-git is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@demilade18-git Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExpiryAlertsServiceonly checked warranty and maintenance expiries, not insurance. AddscheckInsuranceExpiries(), called from the same daily cron run as the existing checks.Closes #1424
Note
Asset(assets/entities/asset.entity.ts) currently has noinsuranceExpiryfield — onlywarrantyExpiry. The new check is a stub matching the existingcheckWarrantyExpiries/checkMaintenanceDuematurity level (both are also TODO stubs with no repository wired in) rather than a real query, since adding the field itself is a separate-file/migration change. Flagged in a comment so the gap doesn't silently reappear once the field is added.Test plan
npm install/build/test — nonode_modulespresent locally