Skip to content

fix: QR manual entry, location drag-and-drop, auth skeleton, sidebar … - #1558

Merged
yusuftomilola merged 1 commit into
DistinctCodes:mainfrom
ggrunlab-pixel:fix/qr-fallback-location-dnd-auth-skeleton-sidebar-highlight
Sep 26, 2026
Merged

yusuftomilola merged 1 commit into
DistinctCodes:mainfrom
ggrunlab-pixel:fix/qr-fallback-location-dnd-auth-skeleton-sidebar-highlight

Conversation

@ggrunlab-pixel

Copy link
Copy Markdown
Contributor

Summary

This PR fixes four independent UI gaps: a missing manual-entry fallback in the QR scanner, missing drag-and-drop in the location hierarchy, a missing loading skeleton during auth init, and broken active-route highlighting on nested routes.

Changes

Closes

Closes #1448
Closes #1452
Closes #1451
Closes #1449

QR scanner manual entry fallback — #1456

  • Added manual asset-ID text entry option in components/qr-scanner.tsx
  • Available when a QR code fails to scan or is damaged, as an alternative to camera scanning

Closes

Closes #1459
Closes #1458
Closes #1453
Closes #1450

Location hierarchy drag-and-drop reordering — #1460

  • Added drag-and-drop support in features/LocationsManagement for reordering and re-parenting locations
  • Structural changes no longer require the form-based edit flow

Closes

Closes #1456
Closes #1460
Closes #1455
Closes #1454

Auth initialization loading skeleton — #1455

  • Added a loading skeleton to components/auth-initializer.tsx while auth state resolves on first load
  • Eliminates the flash of unauthenticated content on initial load

Closes

Closes #1463
Closes #1457
Closes #1462
Closes #1461

Sidebar active-route highlighting on nested routes — #1454

  • Fixed sidebar nav item highlighting to correctly match nested dashboard routes (e.g. an asset detail page under a list route)

Closes

Closes #1466
Closes #1471
Closes #1464
Closes #1465

Testing

  • QR scanner tested with a damaged/unscannable code, confirming manual entry works as fallback
  • Location hierarchy tested for both reordering siblings and re-parenting across levels via drag-and-drop
  • Auth init tested on cold load/refresh, confirming skeleton shows and no unauthenticated flash occurs
  • Sidebar tested on nested routes (e.g. asset detail pages) to confirm correct parent nav item is highlighted

Closes

Closes #1470
Closes #1469
Closes #1468
Closes #1467

…highlight

- Add manual asset-ID entry fallback to QR scanner for failed/damaged scans
- Add drag-and-drop reordering and re-parenting to location hierarchy
- Add loading skeleton to auth-initializer to prevent flash of unauthenticated content
- Fix sidebar active-route highlighting on nested dashboard routes

Closes DistinctCodes#1456
Closes DistinctCodes#1460
Closes DistinctCodes#1455
Closes DistinctCodes#1454
@drips-wave

drips-wave Bot commented Sep 25, 2026

Copy link
Copy Markdown

@ggrunlab-pixel Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

@ggrunlab-pixel is attempting to deploy a commit to the naijabuz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@yusuftomilola
yusuftomilola merged commit d18da76 into DistinctCodes:main Sep 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment