[Fix] /mcp DB 커넥션 누수 수정 - #125
Conversation
spring.jpa.open-in-view 기본값(true)과 MCP Streamable HTTP 응답 처리 방식이 충돌해 /mcp 요청마다 JDBC 커넥션이 반납되지 않던 문제를 해결한다. 전역 OSIV를 끄고 WebMvcConfig에서 /mcp를 제외한 나머지 경로에만 다시 등록해, 다른 API의 기존 동작은 그대로 유지한다.
재현 실패/성공 과정, 원인 좁히기(필터 가설 기각 → OSIV로 확정), 해결 방안과 검증 결과(테스트 706개 통과, 수동 e2e 재현 불가 확인)를 기록한다.
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthrough전역 OSIV를 비활성화하고 ChangesMCP 커넥션 관리
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
레이스 컨디션 수정 배경과 각 필드·메서드의 동작을 이해하기 쉽게 설명하는 주석을 추가한다. 로직 변경 없음.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/design/kangcheolung-`#120-mcp-db-connection-leak-fix.md:
- Line 9: 수정 대상 Markdown 제목에서 `#117`과 괄호 사이에 공백을 추가해 `#117 (Rate Limiting + 출력
정제)` 형식으로 변경하고, 나머지 내용은 유지하세요.
In `@src/main/java/com/opensource/docgrid/global/config/WebMvcConfig.java`:
- Around line 29-43: addInterceptors의 순차 실행 흐름을 주석으로 표시하세요. EntityManagerFactory
조회, 빈이 없을 때 즉시 반환, OpenEntityManagerInViewInterceptor 구성, /mcp를 제외한 인터셉터 등록 단계에
각각 1., 2., 3., 4. 주석을 추가하고 기존 동작과 주석 내용은 유지하세요.
- Line 42: Align the /mcp exclusion logic in WebMvcConfig and
McpApiKeyAuthFilter.shouldNotFilter() so both use the same normalized request
path, including context paths and trailing slashes. Reuse a shared matcher or
normalization rule rather than comparing request.getRequestURI() directly, and
ensure the interceptor and authentication filter exclude exactly the same
requests.
In `@src/main/resources/application.yml`:
- Around line 12-15: Ensure the deployment configuration explicitly preserves
spring.jpa.open-in-view=false by removing any SPRING_JPA_OPEN_IN_VIEW=true
environment overrides and --spring.jpa.open-in-view=true runtime arguments, or
adding an equivalent deployment-level override-prevention step. Verify profile
and Docker Compose configuration do not re-enable OSIV.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8de99731-ffc2-4d9c-a8e4-d0c2c7bbd1c3
📒 Files selected for processing (3)
docs/design/kangcheolung-#120-mcp-db-connection-leak-fix.mdsrc/main/java/com/opensource/docgrid/global/config/WebMvcConfig.javasrc/main/resources/application.yml
| jpa: | ||
| # 전역 OSIV를 끄고, WebMvcConfig에서 /mcp를 제외한 나머지 경로에만 다시 등록한다. | ||
| # /mcp는 MCP Streamable HTTP 응답 처리 방식과 OSIV가 충돌해 DB 커넥션이 누수됐다(#120). | ||
| open-in-view: false |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
if ! rg -n -C 3 \
'spring\.jpa\.open-in-view|open-in-view|SPRING_JPA_OPEN_IN_VIEW' \
--glob '*.yml' \
--glob '*.yaml' \
--glob '*.properties' \
--glob 'Dockerfile*' \
--glob '*.sh' \
.
then
echo "No repository-level override found."
fiRepository: DocGrid/backend
Length of output: 627
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Tracked YAML/YML/properties/XML/Docker/deploy files with possible configuration/env references:\n'
git ls-files | rg '(^|/)(application[^/]*\.(yml|yaml|properties|xml)|Dockerfile|docker-compose.*|.*\.env|.*\.env\..*|.*\.sh)$' || true
printf '\nAll tracked files with JPA open-in-view, WebMvcConfig, or OSIV-related terms:\n'
rg -n -i -C 2 'open-in-view|openInView|OpenInView|WebMvcConfig|webMvc|RequestMappingHandlerMapping|WebMvcConfigurer|DispatcherServlet|JpaBaseConfiguration|JpaWebConfiguration|enableAsyncTransactions|transaction|OSIV|open view' . || true
printf '\nRelevant build/config versions:\n'
for f in pom.xml build.gradle settings.gradle build.gradle.kts settings.gradle.kts gradle.properties; do
[ -f "$f" ] && echo "--- $f" && sed -n '1,220p' "$f"
doneRepository: DocGrid/backend
Length of output: 50372
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'Files containing exact Spring jpa open-in-view or equivalent property/env keys:\n'
rg -n -i --hidden --glob '!target/**' \
'spring\.jpa\.open[-_]?in[-_]?view|spring.jpa.open-in-view|SPRING_JPA[_.]OPEN[-_]?IN[-_]?VIEW|OPEN[-_]?IN[-_]?VIEW' . || true
printf '\nApplication-related configuration files (tracked):\n'
git ls-files | rg '(^|/)(application[^/]*|Dockerfile|docker-compose[^/]*|helmchart|\.github|env|local|dev|prod|prod-)' | sed -n '1,200p'
printf '\nBuild dependency/version files containing spring-boot or jpa references:\n'
git ls-files | rg '(^|/)(pom\.xml|build\.gradle|build\.gradle\.kts|settings\.gradle|gradle\.properties)$' | while read -r f; do
echo "--- $f"
rg -n -i 'spring-boot|spring-boot-starter|spring-boot-starter-jpa|jpa|web|boot-actuator|spring-cloud|java|bootVersion|springBoot' "$f" || true
done
printf '\nLocate WebMvcConfig and dispatcher/web config classes:\n'
git ls-files | rg '(^|/)(WebMvcConfig|Dispatcher|WebMvc.*Config|Async.*Config).*\.(java|kt)$' | while read -r f; do
echo "--- $f"
wc -l "$f"
rg -n -C 4 'class WebMvcConfig|`@Configuration`|WebMvcConfigurer|addInterceptors|RequestMappingHandlerMapping|DispatcherServlet|/mcp' "$f" || true
done
printf '\nRelevant application.yml top section:\n'
sed -n '1,80p' src/main/resources/application.ymlRepository: DocGrid/backend
Length of output: 7034
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '--- build.gradle ---\n'
sed -n '1,140p' build.gradle
printf '\n--- application-local.yml ---\n'
sed -n '1,160p' src/main/resources/application-local.yml
printf '\n--- application-prod.yml ---\n'
sed -n '1,160p' src/main/resources/application-prod.yml
printf '\n--- application-test.yml ---\n'
sed -n '1,160p' src/main/resources/application-test.yml
printf '\n--- docker-compose.yml ---\n'
sed -n '1,180p' docker-compose.yml
printf '\n--- workflow files mentioning env or SPRING_PROFILES_ACTIVE ---\n'
for f in .github/workflows/*.yml .github/workflows/*.yaml; do
[ -f "$f" ] || continue
echo "--- $f"
rg -n -i -C 3 'SPRING_PROFILES_ACTIVE|SPRING_JPA_OPEN_IN_VIEW|env:|secrets|GITHUB|CI|docker|compose|podman' "$f" || true
done
printf '\n--- WebMvcConfig full file ---\n'
sed -n '1,90p' src/main/java/com/opensource/docgrid/global/config/WebMvcConfig.javaRepository: DocGrid/backend
Length of output: 244
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- build.gradle ---'
sed -n '1,140p' build.gradle
printf '%s\n' ''
printf '%s\n' '--- application-local.yml ---'
sed -n '1,160p' src/main/resources/application-local.yml
printf '%s\n' ''
printf '%s\n' '--- application-prod.yml ---'
sed -n '1,160p' src/main/resources/application-prod.yml
printf '%s\n' ''
printf '%s\n' '--- application-test.yml ---'
sed -n '1,160p' src/main/resources/application-test.yml
printf '%s\n' ''
printf '%s\n' '--- docker-compose.yml ---'
sed -n '1,180p' docker-compose.yml
printf '%s\n' ''
printf '%s\n' '--- workflow files mentioning env or SPRING_PROFILES_ACTIVE ---'
for f in .github/workflows/*.yml .github/workflows/*.yaml; do
[ -f "$f" ] || continue
echo "--- $f"
rg -n -i -C 3 'SPRING_PROFILES_ACTIVE|SPRING_JPA_OPEN_IN_VIEW|env:|secrets|GITHUB|CI|docker|compose|podman' "$f" || true
done
printf '%s\n' ''
printf '%s\n' '--- WebMvcConfig full file ---'
sed -n '1,90p' src/main/java/com/opensource/docgrid/global/config/WebMvcConfig.javaRepository: DocGrid/backend
Length of output: 10294
🌐 Web query:
Spring Boot 3.5 JpaBaseConfiguration JpaWebConfiguration open-in-view auto configure web interceptor when true
💡 Result:
In Spring Boot 3.5, the Open EntityManager in View (OSIV) pattern remains enabled by default, which auto-configures the OpenEntityManagerInViewInterceptor when using a Servlet-based web application [1][2][3]. This behavior is managed by the JpaWebConfiguration static inner class within JpaBaseConfiguration [4][1]. The auto-configuration process functions as follows: 1. Activation: The JpaWebConfiguration class is activated when the application is a Servlet-based web application, depends on WebMvcConfigurer, and does not already have an OpenEntityManagerInViewInterceptor or OpenEntityManagerInViewFilter bean defined [1][2]. 2. Property Check: It uses the @ConditionalOnBooleanProperty annotation to check the spring.jpa.open-in-view property, which defaults to true if not explicitly set [1][2]. 3. Interceptor Registration: When enabled, the configuration registers an OpenEntityManagerInViewInterceptor bean [1][2]. It also registers a WebMvcConfigurer bean that adds this interceptor to the application's registry, ensuring it is active for web requests [1][2]. If the property is enabled by default (i.e., not set in the configuration), Spring Boot will issue a warning at startup advising that database queries may be performed during view rendering [1][2][5]. To disable this behavior and the associated warning, you should explicitly set the following property in your application.properties or application.yaml file [3][5][6]: spring.jpa.open-in-view=false
Citations:
- 1: https://github.com/spring-projects/spring-boot/blob/3.5.x/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.java
- 2: https://github.com/spring-projects/spring-boot/blob/v3.5.0/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.java
- 3: https://docs.spring.io/spring-boot/reference/data/sql.html
- 4: https://docs.spring.io/spring-boot/3.5/api/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.JpaWebConfiguration.html
- 5: https://www.baeldung.com/spring-open-session-in-view
- 6: https://stackoverflow.com/questions/30549489/what-is-this-spring-jpa-open-in-view-true-property-in-spring-boot
🌐 Web query:
Spring Boot 3.5 JpaWebConfiguration bean OpenEntityManagerInViewInterceptor bean prevents OSIV auto config addInterceptors
💡 Result:
In Spring Boot, the OpenEntityManagerInViewInterceptor bean is part of the JpaWebConfiguration auto-configuration class [1][2]. This auto-configuration is designed to automatically register the interceptor to support the Open Session in View (OSIV) pattern [1][3]. The auto-configuration is protected by the @ConditionalOnMissingBean annotation, which specifies that it will only run if there are no existing OpenEntityManagerInViewInterceptor or OpenEntityManagerInViewFilter beans present in the application context [1][4]. If you define your own OpenEntityManagerInViewInterceptor bean in your configuration, the Spring Boot auto-configured version will automatically back off and will not register its own interceptor or the associated WebMvcConfigurer [1][5]. This mechanism is intended to allow developers to replace the default interceptor with a custom implementation or to completely disable the default auto-configuration by providing a bean of the specified type [5][6]. If your goal is to disable the default OpenEntityManagerInViewInterceptor behavior, the standard and recommended approach is to set the following property in your application.properties or application.yml file [7][3]: spring.jpa.open-in-view=false This property causes the auto-configuration's conditional check (@ConditionalOnBooleanProperty) to fail, preventing the auto-registration of both the interceptor and the WebMvcConfigurer without requiring you to define custom beans [1][2].
Citations:
- 1: https://github.com/spring-projects/spring-boot/blob/3.5.x/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.java
- 2: https://github.com/spring-projects/spring-boot/blob/v3.5.0/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.java
- 3: https://stackoverflow.com/questions/30549489/what-is-this-spring-jpa-open-in-view-true-property-in-spring-boot
- 4: https://docs.spring.vmware.com/spring-boot/docs/2.7.22.2/api/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.JpaWebConfiguration.html
- 5: Auto-configured OpenEntityManagerInViewInterceptor does not back off when an OpenEntityManagerInViewFilter is only defined as a registration bean spring-projects/spring-boot#15879
- 6: https://stackoverflow.com/questions/73911164/terminate-transactional-boundary-when-open-session-in-view-is-enabled
- 7: OpenEntityManagerInViewInterceptor never closes connections when
spring.mvc.async.request-timeoutis set to-1spring-projects/spring-boot#12110
🌐 Web query:
Spring Boot 3.5 JpaBaseConfiguration.JpaWebConfiguration registry.addWebRequestInterceptor bean OpenEntityManagerInViewInterceptor
💡 Result:
In Spring Boot 3.5, the Open EntityManager in View (OSIV) pattern is handled by the internal static class JpaWebConfiguration, which is nested within JpaBaseConfiguration [1][2]. This configuration ensures that an OpenEntityManagerInViewInterceptor is registered when the spring.jpa.open-in-view property is enabled (which is true by default) and no conflicting beans or filters are present [1][2]. The registration mechanism works as follows: 1. The JpaWebConfiguration class defines an openEntityManagerInViewInterceptor bean [1][2]. 2. It then provides a WebMvcConfigurer bean named openEntityManagerInViewInterceptorConfigurer, which takes the interceptor as a dependency [1][2]. 3. Within this WebMvcConfigurer, the addInterceptors method is overridden to register the interceptor using registry.addWebRequestInterceptor(interceptor) [1][2]. This pattern ensures that the EntityManager remains bound to the current thread for the duration of a web request, allowing for lazy loading of entity associations during view rendering [3]. However, because this is widely considered an anti-pattern due to potential performance and scalability issues, Spring Boot logs a warning at startup if the property is left at its default value of true, advising developers to explicitly configure spring.jpa.open-in-view if they wish to disable it or silence the warning [1][2][4].
Citations:
- 1: https://github.com/spring-projects/spring-boot/blob/3.5.x/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.java
- 2: https://github.com/spring-projects/spring-boot/blob/v3.5.0/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/orm/jpa/JpaBaseConfiguration.java
- 3: https://learn-it-university.com/understanding-the-spring-jpa-open-in-view-property-in-spring-boot/
- 4: https://stackoverflow.com/questions/30549489/what-is-this-spring-jpa-open-in-view-true-property-in-spring-boot
spring.jpa.open-in-view 설정을 배포 환경에서 확정하세요.
프로필 파일과 Docker compose에는 덮어쓰기가 없습니다. 배포 툴체인에 SPRING_JPA_OPEN_IN_VIEW=true나 --spring.jpa.open-in-view=true 같은 실행 인자가 포함되면 기본 OSIV가 적용되어 /mcp 미배제 인터셉터가 함께 등록됩니다. 이 인자는 제거하거나 명시적 오버라이드 방지 단계를 추가하면 됩니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/main/resources/application.yml` around lines 12 - 15, Ensure the
deployment configuration explicitly preserves spring.jpa.open-in-view=false by
removing any SPRING_JPA_OPEN_IN_VIEW=true environment overrides and
--spring.jpa.open-in-view=true runtime arguments, or adding an equivalent
deployment-level override-prevention step. Verify profile and Docker Compose
configuration do not re-enable OSIV.
Source: Path instructions
WebMvcConfig의 OSIV 제외 경로와 McpApiKeyAuthFilter의 인증 제외 경로가 각자 "/mcp" 리터럴을 중복 정의하고 있어, 경로가 바뀌면 한쪽만 갱신될 위험이 있었다. MCP_ENDPOINT 상수를 공개해 두 곳이 같은 값을 참조하게 한다. addInterceptors()에 단계별 번호 주석을 추가하고, 설계 문서의 띄어쓰기를 정리한다. 배포 설정에서 open-in-view를 재정의할 수 있다는 지적은 실제로 application-prod.yml/docker-compose.yml 어디에도 그런 override가 없어 반영하지 않는다.
Summary
/mcp요청마다 JDBC 커넥션이 반납되지 않고 누적되다가 5회째에 풀이 고갈되는 문제를 수정spring.jpa.open-in-view기본값(true)과 MCP Streamable HTTP 응답 처리 방식이 충돌해, OSIV가 커넥션 반납 시점을 인지하지 못함/mcp를 제외한 나머지 경로에만 다시 등록해 다른 API의 기존 동작은 그대로 유지Test plan
./gradlew test— 706개 전체 통과search_documents/get_document_detail각각 5연속 호출 시 100% 재현 (HikariCPactive=5, idle=0타임아웃, Postgres에서 5개 idle+COMMIT 확인)search_documents25연속 + 3개 도구 혼합 20회 호출에서 재현 안 됨 (커넥션 개수 고정)/mcp가 아닌 경로(/auth/login)도 수정 후 정상 동작 확인docs/design/kangcheolung-#120-mcp-db-connection-leak-fix.mdcloses #120
🤖 Generated with Claude Code
Summary by CodeRabbit