공식 OpenSQL 17.8 호환성 및 성능 검증 추가 - #126
Merged
Merged
Conversation
|
Warning Review limit reached
Next review available in: 45 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughOpenSQL 17.8 및 pgvector 0.8.1 환경을 검증하는 호스트 점검 스크립트, 통합 테스트, 전용 Gradle 태스크와 실행 문서를 추가했다. 호환성 테스트는 Flyway, vector, HNSW, Top-K, ChangesOpenSQL 검증
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Verifier
participant openSqlVerification
participant OpenSqlCompatibilityIntegrationTest
participant OpenSQL
Verifier->>openSqlVerification: start OpenSQL verification
openSqlVerification->>OpenSqlCompatibilityIntegrationTest: run compatibility test
OpenSqlCompatibilityIntegrationTest->>OpenSQL: verify migration, vector, HNSW, and SKIP LOCKED
openSqlVerification->>OpenSQL: run Claim, document E2E, and performance tests
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@build.gradle`:
- Around line 168-176: Update openSqlDocumentE2eTest so it requires explicit
MinIO and BGE-M3 target configuration before execution, rather than allowing
defaults or mock settings when only the local-e2e tag is present. Validate the
required URL and secret configuration sources and fail the task clearly when
they are missing, without logging secret values; preserve
configureOpenSqlDatabase for database setup.
In `@docs/test-results/gimin-`#124-opensql-compatibility-performance.md:
- Around line 151-163: 문서의 “전체 실행 결과”에 Swagger 수동 테스트 결과를 추가하십시오. 실제로 수행한 각
Endpoint의 입력 조건, 관찰한 응답, 성공 여부를 기록하고, 아직 수행하지 않았다면 결과를 임의로 작성하지 말고 필요한 Swagger
검증을 먼저 실행한 뒤 반영하십시오.
In `@docs/test-results/gimin-`#124-opensql-verification-runbook.md:
- Around line 229-236: 로컬 기준선 명령의 OPENSQL_DB_PASSWORD에 비밀번호 placeholder를 직접 지정하지
마세요. Section 3의 read -s 방식으로 비밀번호를 환경 변수에 주입한 뒤, openSqlCompatibilityTest 실행 시
기존 환경 변수 OPENSQL_DB_PASSWORD를 재사용하도록 문서를 수정하세요.
- Around line 60-61: Update the password input command in the runbook to disable
read’s escape processing, preserving backslashes exactly in OPENSQL_DB_PASSWORD
and its subsequent use as PGPASSWORD.
- Around line 215-219: Update the namespace discovery query in the runbook so
every literal underscore in the LIKE pattern is escaped, ensuring it matches
only names following the exact docgrid_opensql_..._test structure rather than
treating underscores as single-character wildcards.
In `@scripts/opensql/verify-host.sh`:
- Around line 48-50: server_version 및 vector_version의 psql 실행에서 stderr를 임시 파일에
캡처하고, trap으로 임시 파일을 항상 삭제하도록 변경하세요. psql 실패 시 원본 stderr를 출력하지 말고 연결 또는 버전 조회 실패를
나타내는 일반화된 메시지만 출력하면서 기존 set -e 동작은 유지하세요.
- Around line 48-50: The two psql invocations assigning server_version and
vector_version should run with -X --no-pager and an approved upper-bound
PGCONNECT_TIMEOUT environment setting. Apply these options consistently to both
calls, keeping PGCONNECT_TIMEOUT limited to connection establishment rather than
query timeout behavior.
- Around line 23-38: Update verify-host.sh so it does not claim official OpenSQL
Host validation based only on OPENSQL_INSTALL_MODE, server_version, and pgvector
version. Add the vendor-supported OpenSQL product identifier and Single-topology
evidence checks, or explicitly relabel the output and result as a
compatible-version preflight rather than an official OpenSQL determination.
In
`@src/test/java/com/opensource/docgrid/opensql/OpenSqlCompatibilityIntegrationTest.java`:
- Line 56: Update TEST_SCHEMA in OpenSqlCompatibilityIntegrationTest to append a
short, safe identifier suffix unique to each test JVM or Gradle execution.
Ensure the resulting schema remains valid for the OpenSQL database and is used
consistently by the existing table DDL and DROP SCHEMA ... CASCADE cleanup.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b897c75-df9a-4d3c-aca1-ab76e5218384
📒 Files selected for processing (6)
build.gradledocs/design/gimin-#124-opensql-compatibility-performance.mddocs/test-results/gimin-#124-opensql-compatibility-performance.mddocs/test-results/gimin-#124-opensql-verification-runbook.mdscripts/opensql/verify-host.shsrc/test/java/com/opensource/docgrid/opensql/OpenSqlCompatibilityIntegrationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 내용
vector(1024), HNSW,<=>,SKIP LOCKED를 실제 DB에서 검증합니다.검증
openSqlVerification: 성공검증 환경과 남은 확인
공급사 OpenSQL 3.17.8.7 배포본을 Rocky Linux 9.7 x86-64 Single 컨테이너에서 검증했습니다. Apple Silicon Host의
linux/amd64에뮬레이션 경계이므로 기능 호환성 결과는 유효하지만, 성능값은 SLO로 사용하지 않습니다. 공급사 지원 VM 또는 원격 서버의 최종 인수 검증은 같은 Runbook으로 한 번 더 실행해야 하므로 이슈는 자동으로 닫지 않습니다.설치 번들, 라이선스, 다운로드 정보, 접속 Secret은 Git 변경에 포함하지 않았습니다.
Related to #124
Summary by CodeRabbit
새로운 기능
문서