Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough기본 임베딩 모델의 Changes임베딩 모델 제약 검증
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Test
participant Transaction
participant PostgreSQL
Test->>Transaction: 두 독립 트랜잭션에서 기본 모델 삽입
Transaction->>PostgreSQL: true+true INSERT
PostgreSQL-->>Transaction: 1건 성공, 1건 유니크 위반
Transaction-->>Test: 삽입 결과 반환
Test->>PostgreSQL: 최종 기본 모델 COUNT
PostgreSQL-->>Test: 1건 반환
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
is_active=true AND is_searchable=true만 최대 한 건으로 제한되는지 확인했습니다..dev/learnings/embedding-model-concurrency-verification.md에 기록했습니다.운영 Java 코드, V27 Migration, Seed, API 설정은 변경하지 않았습니다.
동시성 검증 결과
중복 요청의 실패는 시스템 장애가 아니라 SQLSTATE
23505와uk_embedding_models_one_active_searchable인덱스가 잘못된 상태를 차단한 결과입니다.Benchmark 결과
로컬 단일 OpenSQL 컨테이너와 합성 데이터에서 얻은 관찰값이므로 운영 성능으로 일반화하지 않습니다.
이 작업의 핵심 효과는 조회 속도가 아니라 동시성 상황의 데이터 불변식 보장입니다.
테스트
./gradlew cleanTest test ./gradlew benchmarkTest --rerun-taskstmaxopensql/postgres:14.6Closes #12
Summary by CodeRabbit
문서
테스트
개선