Skip to content

feat: add action sonarqube angular#18

Merged
diego-dm-morais merged 39 commits into
mainfrom
feat/update-sonarqube
Jul 10, 2025
Merged

feat: add action sonarqube angular#18
diego-dm-morais merged 39 commits into
mainfrom
feat/update-sonarqube

Conversation

@diego-dm-morais

Copy link
Copy Markdown

No description provided.

@diego-dm-morais
diego-dm-morais requested a review from a team July 10, 2025 17:44
@diego-dm-morais diego-dm-morais self-assigned this Jul 10, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @diego-dm-morais, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new GitHub Action designed to simplify and automate SonarQube analysis for Angular projects. It handles scanning, quality gate checks, and dynamic updates to quality gate thresholds based on coverage metrics, aiming to improve code quality and maintainability.

Highlights

  • New GitHub Action: This PR introduces a new composite GitHub Action for SonarQube scanning of Angular projects.
  • SonarQube Integration: The action automates the process of scanning Angular projects with SonarQube, checking the Quality Gate status, and optionally updating the Quality Gate based on coverage.
  • Coverage Calculation: The action includes a script to calculate coverage from a coverage.xml file.
  • Quality Gate Updates: The action includes a script to update the SonarQube Quality Gate based on the calculated coverage, potentially adjusting the coverage threshold.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new composite GitHub Action for running SonarQube scans on Angular projects. The action automates scanning, checking the quality gate, and dynamically updating the coverage threshold. The review identified a critical issue with the sleep command, several high severity issues including confusing token inputs and implicit dependencies, and medium severity issues such as unused inputs and opportunities to improve maintainability.

Comment thread sonarqube-angular/sonarqube-status.sh
Comment thread sonarqube-angular/action.yml
Comment thread sonarqube-angular/action.yml
Comment thread sonarqube-angular/coverage-calc.sh
Comment thread sonarqube-angular/quality-gates-sonarqube.sh
Comment thread sonarqube-angular/action.yml
Comment thread sonarqube-angular/action.yml
Comment thread sonarqube-angular/coverage-calc.sh
Comment thread sonarqube-angular/quality-gates-sonarqube.sh
Comment thread sonarqube-angular/quality-gates-sonarqube.sh
@diego-dm-morais
diego-dm-morais merged commit 01f9830 into main Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants