Feat improve gmud action#22
Conversation
Summary of ChangesHello @alexandremac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! Este pull request refatora a ação GMUD para aprimorar a geração dos payloads de notificação do Slack. Ao utilizar Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
Olá! Ótima iniciativa em usar jq para construir o payload JSON para o Slack. Isso torna a action mais robusta e evita problemas com caracteres especiais e quebras de linha. Tenho algumas sugestões para simplificar ainda mais o script e melhorar a legibilidade do código jq.
| { | ||
| "type": "mrkdwn", | ||
| "text": "*Responsáveis:*\n• *Dev:* ${{ steps.extract-data.outputs.dev }}\n• *TL:* ${{ steps.extract-data.outputs.tl }}\n• *Team:* ${{ steps.extract-data.outputs.team }}" | ||
| "text": ("*Responsáveis:*\n• *Dev:* " + $dev + "\n• *TL:* " + $tl + "\n• *Team:* " + $team) |
There was a problem hiding this comment.
Para melhorar a legibilidade, você pode usar a interpolação de strings do jq ("\($variable)") em vez de concatenação com +. Isso torna o template JSON mais limpo e fácil de ler.
Esta sugestão pode ser aplicada em todas as concatenações de string neste bloco jq.
"text": "*Responsáveis:*\n• *Dev:* \($dev)\n• *TL:* \($tl)\n• *Team:* \($team)"
Usando JQ para formar o json e evitar problemas com quebra de linhas no template da GMUD.