Skip to content

Feat improve gmud action#22

Merged
alexandremac merged 4 commits into
mainfrom
feat-improve-gmud-action
Nov 10, 2025
Merged

Feat improve gmud action#22
alexandremac merged 4 commits into
mainfrom
feat-improve-gmud-action

Conversation

@alexandremac

Copy link
Copy Markdown

Usando JQ para formar o json e evitar problemas com quebra de linhas no template da GMUD.

@alexandremac
alexandremac requested a review from a team November 10, 2025 18:24
@alexandremac alexandremac self-assigned this Nov 10, 2025
@alexandremac alexandremac added the enhancement New feature or request label Nov 10, 2025
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @alexandremac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Este pull request refatora a ação GMUD para aprimorar a geração dos payloads de notificação do Slack. Ao utilizar jq para a construção do JSON, ele aborda potenciais problemas com quebras de linha e aumenta a robustez geral do processo de notificação, garantindo que as mensagens sejam formatadas corretamente.

Highlights

  • Refatoração da Construção do Payload Slack: A lógica para construir o payload JSON para notificações do Slack foi refatorada para utilizar a ferramenta de linha de comando jq.
  • Prevenção de Problemas de Quebra de Linha: A adoção do jq visa especificamente evitar problemas com quebras de linha que poderiam ocorrer ao gerar o JSON diretamente no template da GMUD, garantindo a formatação correta.
  • Melhoria na Robustez do Template GMUD: A mudança torna a geração do JSON para as notificações mais robusta e menos suscetível a erros de formatação, resultando em mensagens mais consistentes no Slack.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Olá! Ótima iniciativa em usar jq para construir o payload JSON para o Slack. Isso torna a action mais robusta e evita problemas com caracteres especiais e quebras de linha. Tenho algumas sugestões para simplificar ainda mais o script e melhorar a legibilidade do código jq.

Comment thread gmud-creator/action.yml
{
"type": "mrkdwn",
"text": "*Responsáveis:*\n• *Dev:* ${{ steps.extract-data.outputs.dev }}\n• *TL:* ${{ steps.extract-data.outputs.tl }}\n• *Team:* ${{ steps.extract-data.outputs.team }}"
"text": ("*Responsáveis:*\n• *Dev:* " + $dev + "\n• *TL:* " + $tl + "\n• *Team:* " + $team)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Para melhorar a legibilidade, você pode usar a interpolação de strings do jq ("\($variable)") em vez de concatenação com +. Isso torna o template JSON mais limpo e fácil de ler.

Esta sugestão pode ser aplicada em todas as concatenações de string neste bloco jq.

                  "text": "*Responsáveis:*\n• *Dev:* \($dev)\n• *TL:* \($tl)\n• *Team:* \($team)"

Comment thread gmud-creator/action.yml
@alexandremac
alexandremac merged commit 564485b into main Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants