fix(ecr): push sandbox-runner image to synapseai-codeapi-sandbox-runner - #1
Merged
Merged
Conversation
…runner repo
The Enviro ECR placeholder for the NsJail sandbox-runner is named
synapseai-codeapi-sandbox-runner, but this matrix row pushed to
synapseai-codeapi-sandbox, which does not exist in account 323463077991.
The image builds fine; only the push failed:
ERROR: failed to push .../synapseai-codeapi-sandbox:ff5c770:
The repository with name 'synapseai-codeapi-sandbox' does not exist
in the registry with id '323463077991'
Align the push target with the repo that exists. The deploy spec
(hydra/synapseai specs/dev/code-intepreter.yaml) is updated to pull the
same name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
synapseai-codeapi-sandbox-runner-deploynever started on the DEV deployment because its image does not exist in ECR. The image builds fine — only the push failed, every run:Evidence (GitHub Actions):
ff5c7706b0af13b29ec82The Enviro ECR placeholder for this image is
synapseai-codeapi-sandbox-runner, but this matrix row pushed tosynapseai-codeapi-sandbox, which does not exist in account323463077991.synapseai-codeapi-package-initfailed the same way and its repo now exists.Change
Align the push target with the repo that exists:
synapseai-codeapi-sandbox-runner.The consumer is updated in lockstep —
hydra/synapseaispecs/dev/code-intepreter.yamlpulls the same name.Not in this PR
docker pushcannot create an ECR repo;synapseai-codeapi-sandbox-runnermust be created in323463077991(and in the destination registry245094849113for the sync job).CODEAPI_IMAGE_TAGinhydra/synapseaimust be set to that new short SHA (it currently pins6b0af13, which predates both the no-KVMsandbox-runnertarget and the package-init row).ENC[{CODEAPI_MANIFEST_PUBLIC_KEY_ENC}]/ENC[{CODEAPI_MANIFEST_PRIVATE_KEY_ENC}]incode-intepreter.yamlare never substituted by CI, so withCODEAPI_HARDENED_SANDBOX_MODE=trueandSANDBOX_REQUIRE_EGRESS_MANIFEST=true, sandbox execution fails signature verification even once the image exists.synapseai-codeapi-sandbox-packages(ReadWriteOnce); whichever pod attaches first blocks the other.Why not reuse an existing image
There is no substitute. The
synapseai-codeapi-workerimage was temporarily used for both services and reverted infd68789("correct images are needed") — neither service can run the worker image.Note on the image target
--target sandbox-runner(directory root) is correct for Momentum: nodes arem5(Xen) with no/dev/kvm, so the baked/KVM target is unusable and packages come from the PVC via the package-init Job.