fix: register shell completion for the installed binary name

[kmannislands]

Fixes #804.

Problem

bootstrap --with-autocomplete hardcoded earthly as the command word in both the bash and zsh completion entries, and wrote them to files named earthly / _earthly. Only the completer's executable path was substituted. Since the released binary is earth, shells never loaded the entry and earth <TAB> offered nothing.

Change

The command word and the completion filenames are now derived from the basename of the running executable.

The installation name (--installation-name) is deliberately not used as the source: it names on-disk resources (~/.earthly, the buildkitd container, the cache volume) and can be overridden independently of the name the user actually types.

A binary still installed as earthly registers both earthly and earth, matching the alias symlinkEarthlyToEarth already creates for it.

As a side effect, bashCompleteEntry / zshCompleteEntry became pure functions of (earthPath, cmdName), which drops the renderEntryTemplate string-substitution indirection and makes them directly testable.

Note

docs/alt-installation/alt-installation.md already documents removing /usr/share/bash-completion/completions/earth and /usr/local/share/zsh/site-functions/_earth on uninstall — the docs described this behavior, the code just never did it.

Testing

• New unit tests in cmd/earth/subcmd/bootstrap_cmds_test.go cover the name derivation (earth, legacy earthly + alias, custom name) and both rendered entries.
• tests/bootstrap/test-bootstrap.sh no longer hardcodes the completion filename — it derives it from the binary under test and additionally asserts the registered command word. This keeps working when the integration suite moves to driving earth (test: drive the earth binary throughout the integration suite #803).
• tests/autocompletion/install/Earthfile now asserts the command word each file registers, and that the earth alias file is installed alongside earthly. The root-user target checks neither name lands under /root.

go build ./..., go vet ./cmd/earth/... and go test ./cmd/earth/subcmd/ pass locally. The Earthfile-driven autocompletion and bootstrap suites run in CI.

🤖 Generated with Claude Code

[github-actions]

🎉 Are we earthbuild yet?

Great progress! You've reduced "earthly" occurrences by 5 (0.14%)

📈 Overall Progress

Branch	Total Count
main	3617
This PR	3612
Difference	-5 (0.14%)

📁 Changes by file type:

File Type	Change
Go files (.go)	✅ -5
Documentation (.md)	❌ +1
Earthfiles	❌ +1

---

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurrences of earthly in the source code due to backwards compatibility with config files and language constructs.

[janishorsts]

LGTM.

As this is a temporary implementation, I'm not going to leave more comments to simplify.

[kmannislands]

Pushed a fix for a real CI failure that appeared after rebasing onto main.

tests/autocompletion/install/Earthfile asserted that bootstrap registers both earthly and earth, which was true when the test image installed the CLI as earthly. Since #796 landed on main the image installs it as earth, so only earth is registered and the hardcoded $path/earthly assertion failed with No such file or directory in test-bash-non-root-fallback-dir and test-bash-non-root-xdg-dir.

The production behaviour is correct — registering earthly for a binary installed as earth is exactly what this PR removes. It was the test that carried the stale assumption. It now derives the expected command word from the binary under test, matching what test-bootstrap.sh already does, and only requires the earth alias file when the binary really is installed as earthly, so it keeps working under either name:

cmd="$(basename "$(readlink -f "$(command -v earth)")")"
grep "^complete" "$path/$cmd" && grep -q "$cmd\$" "$path/$cmd" && \
    if [ "$cmd" = earthly ]; then grep -q "earth$" "$path/earth"; fi && ...

I also updated test-bash-non-root-no-overwrite, which had the same hardcoded name (it is not in +test-all, so it was not failing, just stale).

Verified the assertion locally against both an earth-named and an earthly-named binary, plus a negative control confirming it still fails when the alias file is genuinely missing.

Two other red checks are not from this PR:

• Go Vulnerabilities Report — failing on main itself, same 10 CVEs in containerd/docker deps. Needs a separate dependency bump.
• Race Tests (Misc) / EarthBuild Image Test — local registry flake (pullping blob fetch returning EOF mid-pull); no data races or test failures in the logs.