Skip to content

test: update tests to reference earth and earthbuild - #988

Merged
janishorsts merged 2 commits into
mainfrom
test-earthly-to-earth
Oct 8, 2026
Merged

janishorsts merged 2 commits into
mainfrom
test-earthly-to-earth

Conversation

@janishorsts

@janishorsts janishorsts commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated test scenarios to use the earth command name and current repository and container naming.
    • Existing completion, secret-redaction, version-check, logging-prefix, and container-name expectations remain unchanged apart from corresponding name updates.

@janishorsts janishorsts self-assigned this Sep 30, 2026
@janishorsts
janishorsts requested a review from a team as a code owner September 30, 2026 15:02
@janishorsts
janishorsts requested review from gilescope and removed request for a team September 30, 2026 15:02
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 757223f1-9f31-4546-aff7-0155b01a9838
📥 Commits

Reviewing files that changed from the base of the PR and between c8da0bc and fc2f02e.

📒 Files selected for processing (5)
  • autocomplete/complete_test.go
  • cmd/earth/app/run_test.go
  • conslogging/conslogging_test.go
  • features/features_unexported_test.go
  • internal/engine/shell_test.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

Test inputs and fixtures now use updated command, repository, and container name strings. Expected results change where the repository prefix or parsed proxy name changed.

Changes

Test name updates

Layer / File(s) Summary
Command name test cases
autocomplete/complete_test.go, cmd/earth/app/run_test.go, features/features_unexported_test.go
The test cases use “earth” instead of “earthly.” Existing completion and redaction expectations remain unchanged.
Repository prefix test cases
conslogging/conslogging_test.go
The repository path changes to github.com/earthbuild/earthbuild. Expected shortened prefixes and padding are updated in the affected cases.
Container name test fixture
internal/engine/shell_test.go
The fixture and expected parsed proxy name use the “earth-” prefix. Other fixture values remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to fc2f0

The PR updates test references to the new command, repository, and container names. No actionable merge-blocking behavior change is established.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the test updates from “earthly” to “earth” and “earthbuild,” which match the changes in the pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🎉 Are we earthbuild yet?

Great progress! You've reduced "earthly" occurrences by 47 (1.71%)

📈 Overall Progress

Branch Total Count
main 2741
This PR 2694
Difference -47 (1.71%)

📁 Changes by file type:

File Type Change
Go files (.go) ✅ -47
Documentation (.md) ➖ No change
Earthfiles ➖ No change

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurrences of earthly in the source code due to backwards compatibility with config files and language constructs.

@janishorsts
janishorsts enabled auto-merge (squash) October 7, 2026 10:44
@janishorsts
janishorsts disabled auto-merge October 8, 2026 10:45
@janishorsts
janishorsts merged commit da4bc24 into main Oct 8, 2026
99 of 102 checks passed
@janishorsts
janishorsts deleted the test-earthly-to-earth branch October 8, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants