Remove the offline check from metering startup - #36
Merged
Merged
Conversation
Metering startup no longer checks OFFLINE: the checks in ensure_metering_runtime and metering_lifespan are removed, along with ConfigDict.is_offline() and the tests that set or asserted OFFLINE.
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metering-provider startup no longer checks the offline setting. Offline mode keeps the ground from contacting the cloud and has nothing to do with metering, but
ensure_metering_runtimeandmetering_lifespanboth skipped startup when it was on, so a ground running offline never started its meter driver.Both checks are removed, along with
ConfigDict.is_offline()and the tests that asserted the skip. With no driver registered, startup still skips through the existing "metering provider is not configured" path.