Skip to content

Refactoring work #193

Description

@2e0byo
  • Methods which don't use self should be static or classmethods.
    We have quite a lot of these in things like TextBlock.parse. Personally I'd also like to rename this .from_json.
  • Remove sentinel None on class where not optional (over-use of optionals) (See also Spec of Session should be fully exposed on class #192)
  • Set spec on class (see also Spec of Session should be fully exposed on class #192)
  • Use ABCs to enforce consistent spec of objects, e.g. artist/album
  • Config needs refactoring
  • (easy: good first PR) we should clean up old syntax, e.g. inheriting from object, super(class, self) -> super()

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions