refactor: make blog feature and content improvements - #1416
Draft
f15u wants to merge 2 commits into
Draft
Conversation
Member
Author
|
@IMax153 I've split up the MR, so this is focused just on the refactor without any other commit. |
IMax153
reviewed
Jul 31, 2026
IMax153
left a comment
Member
There was a problem hiding this comment.
Can the tests live in a separate top-level test dir? I don't like co-locating them in projects.
IMax153
reviewed
Jul 31, 2026
Comment on lines
+37
to
+53
| static readonly layerTest = (fixtures: { | ||
| readonly posts?: ReadonlyArray<BlogPostSource> | undefined | ||
| readonly tags?: ReadonlyArray<BlogTagSource> | undefined | ||
| readonly authors?: ReadonlyArray<BlogAuthorSource> | undefined | ||
| }) => | ||
| Layer.succeed(this, { | ||
| posts: Effect.succeed(fixtures.posts ?? []), | ||
| tags: Effect.succeed(fixtures.tags ?? []), | ||
| authors: Effect.succeed(fixtures.authors ?? []), | ||
| }) | ||
|
|
||
| static readonly layerFailing = (error: BlogContentError) => | ||
| Layer.succeed(this, { | ||
| posts: Effect.fail(error), | ||
| tags: Effect.fail(error), | ||
| authors: Effect.fail(error), | ||
| }) |
Member
There was a problem hiding this comment.
These layers should probably just be defined in the tests / where they are needed.
f15u
marked this pull request as draft
July 31, 2026 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
These are bugs fixed:
trailingSlash: "never"/blog?category=x(category read from window during the render instead of after)BlogIndex)getCollectionwas called once per static page (171×) instead of oncereadingTimeschema field removed;"release" → "releases"typo in suggested tags fixedRelated