Skip to content

feat: updating minor features - #106

Merged
TEJASNARAYANS merged 2 commits into
mainfrom
call-import-upgrades
Aug 3, 2026
Merged

feat: updating minor features#106
TEJASNARAYANS merged 2 commits into
mainfrom
call-import-upgrades

Conversation

@TEJASNARAYANS

@TEJASNARAYANS TEJASNARAYANS commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

What Changed?

Briefly describe what this PR changes.

Why?

Explain the problem this solves and why this approach was chosen.

How to Test?

List clear steps for reviewers to verify the change.

Release Label

Select one semantic version bump intent for this PR:

  • major - breaking change, next release bumps major version
  • minor - backward-compatible feature, next release bumps minor version
  • fix - backward-compatible bug fix, next release bumps patch version
  • No label (defaults to patch release)

If you do not have permission to apply labels, mention the intended release label here and a maintainer will set it.

Checklist

  • I have read the CONTRIBUTING.md guide.
  • My code follows the project's style guidelines.
  • I have added tests that prove my fix is effective or my feature works.
  • I have updated documentation where needed.

@TEJASNARAYANS TEJASNARAYANS added the fix Fix version release label Jul 31, 2026
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds production-transcript evaluation support and several call-import, reporting, sharding, dispatch, and frontend usability updates.

  • Adds production versus diarised transcript selection throughout evaluation creation, display, export, and reporting.
  • Updates call-import row mutations and evaluation dispatch behavior for sharded deployments.
  • Adds metric clipboard utilities and related frontend controls.
  • Expands API and worker test coverage for the changed evaluation and sharding paths.

Confidence Score: 4/5

The PR is not yet safe to merge because production evaluations can still stall after slot expiry and can materialize rows lacking the selected transcript.

Recording-import cleanup remains gated on a live evaluation slot, leaving stale task IDs after expiry, while production materialization still selects every source row and overwrites the transcript-filtered total.

Files Needing Attention: app/workers/tasks/process_call_import_row.py; app/services/call_imports/bulk_ops.py

Important Files Changed

Filename Overview
app/workers/tasks/process_call_import_row.py Adds production-evaluation handoff behavior, but slot-expired tasks still bypass the cleanup needed to make pending rows dispatchable.
app/services/call_imports/bulk_ops.py Adds production-transcript counting, but evaluation materialization still inserts all source rows and replaces the filtered total.
app/api/v1/routes/call_import_evaluations.py Introduces production-transcript configuration, validation, counting, and response serialization across evaluation routes.
app/db_sharding/scatter_gather.py Adds sharded counting support for source rows containing production transcripts.
frontend/src/pages/callImports/CallImportDetail.tsx Adds transcript-source selection and associated call-import evaluation UI behavior.
frontend/src/pages/metrics/metricClipboardUtils.ts Adds metric clipboard serialization and parsing utilities.

Comments Outside Diff (2)

  1. app/workers/tasks/process_call_import_row.py, line 604 (link)

    P1 Expired slots skip evaluation recovery

    When a production-transcript evaluation's recording import exceeds the 20-minute evaluation-slot lifetime, this guard skips task-ID cleanup and redispatch. The pending evaluation row retains its stale celery_task_id, so fair dispatch excludes it and scoring remains stalled.

  2. app/services/call_imports/bulk_ops.py, line 318-319 (link)

    P1 Production rows bypass transcript filtering

    When a production-source evaluation contains populated and blank production transcripts, _all_source_row_ids selects every row and this assignment replaces the filtered total with the full count. Rows without the selected transcript then enter dispatch and fail or produce unusable evaluation results.

Reviews (2): Last reviewed commit: "fix: updating test cases" | Re-trigger Greptile

@TEJASNARAYANS
TEJASNARAYANS merged commit 5a6e2f7 into main Aug 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix version release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant