HydroBaseX: HydroBase feature porting, Aphi GF, conditional storage and inits. - #385
Open
Jimbo-Coder wants to merge 1 commit into
Open
Jimbo-Coder wants to merge 1 commit into
Jimbo-Coder wants to merge 1 commit into
Conversation
Move HydroBaseX closer to a true HydroBase/Carpet port by adding the missing optional initialization parameters: `initial_Y_e`, `*_Bvec`, `*_Avec`, `*_Aphi`, `*_temperature`, and `*_entropy`. These parameters declare which thorn provides each optional field, with HydroBaseX handling the built-in zero/one initialization cases. Add Aphi as a HydroBaseX GF with AsterX-consistent vvv centering. Add zeroing routines for Bvec, Avec, Aphi, temperature, and entropy, and add the Y_e one routine. Rho, press, eps, and vel are always stored, while the remaining optional fields are now only stored conditionally.
Author
|
This PR to HydroBaseX would ideally go with #386 which makes similar changes to ADMBaseX, porting the conventions set forth by HydroBase/ADMBase respectively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move HydroBaseX closer to a true HydroBase/Carpet port by adding the missing optional initialization parameters:
initial_Y_e,*_Bvec,*_Avec,*_Aphi,*_temperature, and*_entropy. These parameters declare which thorn provides each optional field, with HydroBaseX handling the built-in zero/one initialization cases.Add Aphi as a HydroBaseX GF with AsterX-consistent vvv centering. This is the electric potential, which rounds out the EM support with Bvec, Avec, and Aphi all being treated consistently.
Add zeroing routines for Bvec, Avec, Aphi, temperature, and entropy, and add the Y_e one routine.
Rho, press, eps, and vel are always stored, while the remaining optional fields are now only stored conditionally, consistent with HydroBase's treatment.