[GEN-1815] Create FF for coin selection closest strategy - #562
Open
imclvr wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an environment-driven feature flag to enable/disable a new “closest amount” UTXO coin selection strategy from NodeGuard configuration, with local dev defaults set to disabled.
Changes:
- Introduces
ENABLE_COIN_SELECTION_BY_CLOSESTfeature flag inConstantsand wires it toENABLE_COIN_SELECTION_BY_CLOSESTenvironment variable parsing. - Adds the new environment variable (default
"false") to local launch configurations for bothdotnetand VS Code.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Properties/launchSettings.json |
Adds ENABLE_COIN_SELECTION_BY_CLOSEST=false to local dev environment variables. |
src/Helpers/Constants.cs |
Defines and initializes the new feature flag from environment variables. |
.vscode/launch.json |
Adds ENABLE_COIN_SELECTION_BY_CLOSEST=false to VS Code debug environment variables. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF for enabling new utxo selection from NG.
Stack created with GitHub Stacks CLI • Give Feedback 💬