[GEN-1815] Implement closest utxo selection algorithm - #565
Open
imclvr wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a “closest-to-amount” UTXO selection algorithm in UTXOSelectionAlgorithms and adds/updates unit tests to validate both the new selection behavior and the CoinSelectionService routing flag.
Changes:
- Implemented
SelectUTXOsByClosestand refactored shared argument/funding validation into a helper method. - Added dedicated unit tests for the closest-selection algorithm, plus shared “no UTXOs” / “insufficient funds” coverage for both algorithms.
- Strengthened an existing CoinSelectionService test to ensure the “closest” path produces a non-empty, distinguishable selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/NodeGuard.Tests/Services/CoinSelectionServiceTests.cs | Tightens the closest-selection routing assertion by ensuring the expected selection is non-empty. |
| test/NodeGuard.Tests/Helpers/UTXOSelectionAlgorithmsTests.cs | Adds focused unit tests for the closest-selection algorithm plus shared edge-case coverage. |
| src/Helpers/UTXOSelectionAlgorithms.cs | Implements closest-selection and introduces shared validation logic for selection algorithms. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title self-explanatory
Stack created with GitHub Stacks CLI • Give Feedback 💬