Drop agents beyond consts::kMaxAgentCount - #124
Merged
Merged
Conversation
SamanKazemkhani
requested review from
aaravpandya,
daphne-cornelisse and
eugenevinitsky
May 16, 2024 20:31
Contributor
|
Just to clarify, say there are 150 agents (vehicles + pedestrians + cyclists) and |
Contributor
|
Another check: Can we control vehicles, cyclists, and pedestrians? |
Collaborator
Author
|
Yes, that's correct |
daphne-cornelisse
approved these changes
May 16, 2024
aaravpandya
requested changes
May 18, 2024
aaravpandya
left a comment
Collaborator
There was a problem hiding this comment.
Just removing this assert will not ensure dropping agents beyond kMaxAgentCount. The JsonSerialization.hpp does not respect the kMaxAgentCount bound.
eugenevinitsky
approved these changes
May 22, 2024
aaravpandya
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This alters the behavior of gpudrive to avoid constructing agents if
consts::kMaxAgentCountalready exist.