Dont init invalid agents at first time step. - #130
Merged
Merged
Conversation
aaravpandya
requested review from
SamanKazemkhani,
daphne-cornelisse and
eugenevinitsky
May 22, 2024 01:18
Merged
aaravpandya
force-pushed
the
ap_FixStaticInit
branch
from
May 23, 2024 00:45
a1bca91 to
02fff3b
Compare
aaravpandya
requested review from
SamanKazemkhani,
daphne-cornelisse and
eugenevinitsky
May 23, 2024 00:54
| .def_rw("IgnoreNonVehicles", &Parameters::IgnoreNonVehicles) | ||
| .def_rw("roadObservationAlgorithm", &Parameters::roadObservationAlgorithm); | ||
| .def_rw("roadObservationAlgorithm", &Parameters::roadObservationAlgorithm) | ||
| .def_rw("initInvalidAgentsAtFirstStep", &Parameters::initInvalidAgentsAtFirstStep); |
Contributor
There was a problem hiding this comment.
think I'd call this initOnlyValidAgentsAtFirstStep (though you have to flip true->False, false->true to match the semantics of this name change). The reason is that you can't initInvalidAgents at the first step, they don't exist until later to the user even if they exist inside the sim
eugenevinitsky
approved these changes
May 23, 2024
eugenevinitsky
left a comment
Contributor
There was a problem hiding this comment.
Suggestion to reverse the semantics but otherwise sg
| bool IgnoreNonVehicles = false; // Default: false | ||
| FindRoadObservationsWith roadObservationAlgorithm{ | ||
| FindRoadObservationsWith::KNearestEntitiesWithRadiusFiltering}; | ||
| bool initOnlyValidAgentsAtFirstStep = true; // Default: false |
Collaborator
Author
There was a problem hiding this comment.
Yes you are right :D Missed the comment.
eugenevinitsky
approved these changes
May 23, 2024
wangbingke0
pushed a commit
to wangbingke0/gpudrive
that referenced
this pull request
Feb 13, 2026
* Dont init agents if not valid on first timestep * Add param * Change name and fix test * Change comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dont init agents that are invalid at the first time step.