Skip to content

feat: canonical workspace.mode + workspace.path model - #515

Merged
christso merged 8 commits into
mainfrom
feat/issue-514-workspace-mode-path
Mar 10, 2026
Merged

feat: canonical workspace.mode + workspace.path model#515
christso merged 8 commits into
mainfrom
feat/issue-514-workspace-mode-path

Conversation

@christso

@christso christso commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • canonicalize workspace config to workspace.mode (pooled|temp|static) + workspace.path
  • remove legacy CLI workspace controls and keep only --workspace-mode / --workspace-path
  • enforce precedence and validation rules from feat: workspace.static soft override with env-var fallback #514 (path implies static, conflicts hard-error, static requires path)
  • hard-reject removed legacy fields: workspace.static_path, workspace.pool, and target-level workspace_template
  • update tests and regenerate eval schema reference
  • fix examples/features/workspace-setup-script to install plugin via plugins in workspace config using a project-scoped marketplace

Validation

  • pre-push hooks: build, typecheck, lint, test all passed
  • focused CLI/core behavior checks for workspace flags and mode/path semantics

Manual E2E (2026-03-10)

  • agentv eval --help
    • shows only --workspace-mode and --workspace-path
    • legacy flags absent: --keep-workspaces, --cleanup-workspaces, --retain-on-success, --retain-on-failure, --pool-workspaces, --no-pool, --workspace-clean, --workspace
  • agentv eval examples/features/rubric/evals/dataset.eval.yaml --dry-run --workspace-path /tmp --workspace-mode temp
    • fails with: --workspace-path requires --workspace-mode=static (or omit --workspace-mode)
  • agentv eval examples/features/rubric/evals/dataset.eval.yaml --dry-run --workspace-path /tmp
    • succeeds (Total tests: 5)
  • temp eval YAML with only:
    • workspace.path: /tmp
    • succeeds (Total tests: 1) showing YAML path implies static mode
  • temp eval YAML with:
    • workspace.mode: static and no workspace.path
    • fails with: workspace.mode=static requires workspace.path or --workspace-path
  • temp eval YAML with removed field:
    • workspace.static_path
    • fails with: workspace.static_path has been removed. Use workspace.path with workspace.mode=static.
  • temp eval YAML with removed field:
    • workspace.pool: true
    • fails with: workspace.pool has been removed. Use workspace.mode='pooled' or 'temp'.

Manual E2E: workspace-setup-script example (2026-03-10)

  • agentv eval examples/features/workspace-setup-script/evals/dataset.eval.yaml --dry-run --target copilot
    • exit 0
    • setup hook output confirms:
      • initial workspace init run
      • allagents plugin marketplace add <...>/examples/features/workspace-setup-script/marketplace --scope project
      • allagents workspace sync
      • plugin my-plugin@workspace-setup-script-marketplace synced
  • agentv eval examples/features/workspace-setup-script/evals/dataset-vscode.eval.yaml --dry-run --target vscode
    • exit 0
  • required artifacts check in setup hook passed for:
    • AGENTS.md
    • .github/prompts/summarize-repo.prompt.md

Closes #514

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 10, 2026

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 85960a0
Status: ✅  Deploy successful!
Preview URL: https://b505db9f.agentv.pages.dev
Branch Preview URL: https://feat-issue-514-workspace-mod.agentv.pages.dev

View logs

@christso
christso marked this pull request as ready for review March 10, 2026 03:02
@christso
christso merged commit 9452e93 into main Mar 10, 2026
1 check passed
@christso
christso deleted the feat/issue-514-workspace-mode-path branch March 10, 2026 03:02
christso added a commit that referenced this pull request Mar 10, 2026
…bled

Update documentation across SKILL.md, configuration.mdx, workspace-pool.mdx,
and running-evals.mdx to reflect PR #515 and PR #516 changes:
- Rename ephemeral -> temp in workspace mode enum
- Rename static_path -> path
- Document hooks.enabled option (boolean, default true)
- Document static workspace auto-materialisation when path is empty/missing
christso added a commit that referenced this pull request Mar 10, 2026
…bled (#519)

Update documentation across SKILL.md, configuration.mdx, workspace-pool.mdx,
and running-evals.mdx to reflect PR #515 and PR #516 changes:
- Rename ephemeral -> temp in workspace mode enum
- Rename static_path -> path
- Document hooks.enabled option (boolean, default true)
- Document static workspace auto-materialisation when path is empty/missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: workspace.static soft override with env-var fallback

1 participant