feat(workspace): auto-materialise static workspace when path is empty or missing - #517
Merged
Merged
Conversation
… or missing (#516) When workspace.mode=static with workspace.path, the orchestrator now auto-materialises the workspace (copies template, clones repos) at the defined path if the directory doesn't exist or is empty. Existing populated directories are reused as-is. Also adds workspace.hooks.enabled option (default: true) to allow skipping all workspace hooks for static workspaces. Changes: - orchestrator.ts: detect empty/missing static path, mkdir + copy template + clone repos; add hooksEnabled guard to all hook callsites - types.ts: add enabled?: boolean to WorkspaceHooksConfig - yaml-parser.ts: parse hooks.enabled, merge in workspace config - eval-file.schema.ts: add enabled to WorkspaceHooksSchema - manager.ts: export copyDirectoryRecursive for reuse - Regenerated eval-schema.json - Added tests for static materialisation and hooks.enabled parsing
Deploying agentv with
|
| Latest commit: |
36c0089
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f846ee83.agentv.pages.dev |
| Branch Preview URL: | https://feat-516-auto-materialise-st.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #516
workspace.mode=staticwithworkspace.path, the orchestrator now auto-materialises the workspace (copies template, clones repos) at the defined path if the directory doesn't exist or is empty. Existing populated directories are reused as-is.workspace.hooks.enabledoption (default:true) to allow skipping all workspace hooks for static workspaces.workspace.path), not CLI flags (--workspace/--workspace-path), which always reuse the directory as-is for backward compatibility.Three cases handled
mkdir -p, then materialise (copy template, clone repos, run setup hooks)Files changed
packages/core/src/evaluation/orchestrator.ts-- static workspace auto-materialisation logic +hooksEnabledguard on all hook callsitespackages/core/src/evaluation/types.ts--enabled?: booleanonWorkspaceHooksConfigpackages/core/src/evaluation/yaml-parser.ts-- parsehooks.enabled, merge in workspace configpackages/core/src/evaluation/validation/eval-file.schema.ts--enabledinWorkspaceHooksSchemapackages/core/src/evaluation/workspace/manager.ts-- exportcopyDirectoryRecursiveplugins/agentv-dev/.../eval-schema.json-- regeneratedhooks.enabledparsingTest plan
bun run buildpassesbun run testpasses (962 + 52 + 163 tests, 0 failures)bun run lintpasseshooks.enabled(3 tests)skips template copy and repo materialization when workspace providedstill passes (backward compat for--workspaceflag)