Skip to content

Publish workflow silently publishes nothing when the release tag isn't a MinVer version #600

Description

@alexeyzimarev

The 0.17.0 release was first tagged v0.17.0. MinVer has no MinVerTagPrefix configured, so it ignored the tag and computed 0.16.5-alpha.0.31 from the previous 0.16.4 tag. That prerelease had already been pushed by the preview workflow, so every dotnet nuget push reported "already exists", which --skip-duplicate swallowed. The Publish NuGet run went green without publishing anything (https://github.com/Eventuous/eventuous/actions/runs/35508816930).

Options (not mutually exclusive):

  • Set <MinVerTagPrefix>v</MinVerTagPrefix>, or otherwise accept both 0.x.y and v0.x.y tags. The current convention is bare tags, so this would need to be decided explicitly.
  • Add a guard step in publish.yml that fails when the tag isn't a valid SemVer version, or when the packed package version doesn't equal the tag name.
  • Restrict the workflow's tags filter to a version pattern (e.g. '[0-9]+.[0-9]+.[0-9]+*') so stray tags don't trigger a publish run at all.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgithub_actionsPull requests that update GitHub Actions code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions