feat: DisruptorFiring event addition - #362
Merged
Merged
Conversation
Author
|
i still don't know how to block audio T_T |
louis1706
marked this pull request as draft
January 10, 2025 21:15
|
i put it as Draft since you don't want it to be merged now |
skyfr0676
marked this pull request as ready for review
January 13, 2025 21:34
louis1706
approved these changes
Jan 13, 2025
VALERA771
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes: add the DisruptorFiring event on the Item handler
What is the new behavior? Actually the particle disruptor still shoot even if we drop the item. So this event is called for this. Added from https://discord.com/channels/656673194693885975/663978314683252777/1322013909972156496
Does this PR introduce a breaking change? No
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other