fix: PlayGunSound Extensions fix - #386
Merged
Merged
Conversation
Author
|
Note: Doing things like in PlayGunSound with dummy staying near you works as expected |
VALERA771
marked this pull request as ready for review
January 10, 2025 16:09
obvEve
approved these changes
Jan 10, 2025
Author
|
After playing sound player get kicked |
louis1706
requested changes
Jan 13, 2025
Author
|
Okay so very strange situation. If we use Fake Sync vars we need delay but if we do like everything works fine without delays |
so why we don't use this ? |
Author
|
Cuz someone may use host in some stuff (idk which but it can be used) so if we set it's role for everybody it'll also appear in alive players in spectators list |
oh didn't seen you used CurrentItem |
louis1706
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Brings back PlayGunSound extension
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Currently volume of sound is very low. Seems like it depends on gun position but idk how to move gun closer to player so it will work (creating instance in Server.Host inv and move it to player doesn't work). I hope that someone has an idea how to do this
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other