Skip to content

fix: fixed npc health - #420

Merged
louis1706 merged 11 commits into
ExMod-Team:devfrom
Bonjemus:dev
Apr 20, 2025
Merged

fix: fixed npc health#420
louis1706 merged 11 commits into
ExMod-Team:devfrom
Bonjemus:dev

Conversation

@Bonjemus

@Bonjemus Bonjemus commented Jan 30, 2025

Copy link
Copy Markdown

Description

Describe the changes
https://discord.com/channels/656673194693885975/1300857604620161064
NPC's health works correctly.
Custom role is removed even if it's the same roletype.

What is the current behavior? (You can also link to an open issue here)
NPC's health was always at 0, the custom health stat did nothing.
Custom role wasn't updated when a custom role A with a role was given to a player that already had custom role B with same role.

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Yes.
HumeShieldStat is now obsolete.

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@Bonjemus

Bonjemus commented Feb 1, 2025

Copy link
Copy Markdown
Author

@VALERA771 VALERA771 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that nothing will be broken

Comment thread EXILED/Exiled.API/Features/Player.cs Outdated
Co-authored-by: VALERA771 <72030575+VALERA771@users.noreply.github.com>
Comment thread EXILED/Exiled.API/Features/Npc.cs
Comment thread EXILED/Exiled.Events/Patches/Events/Map/ExplodingFlashGrenade.cs Outdated
@Bonjemus

Copy link
Copy Markdown
Author

@Misfiy

@VALERA771

Copy link
Copy Markdown

I think some conditions in flashbang are wrong. Can you check if all good?

Comment thread EXILED/Exiled.API/Features/Player.cs Outdated
@Bonjemus Bonjemus closed this Mar 17, 2025
@Bonjemus Bonjemus reopened this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants