feat: buttons array - #752
Merged
Merged
Conversation
Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com>
Change comments
louis1706
approved these changes
Feb 14, 2026
Someone-193
approved these changes
Feb 19, 2026
Someone-193
left a comment
Collaborator
There was a problem hiding this comment.
bro why are there that many commits for a 2 line change XD
that why we Squash lol |
louis1706
added a commit
that referenced
this pull request
Mar 31, 2026
* Adds a event that is called after player stops talking with 1576 * Simplify initialization of TransmissionEnded event. * should be no more warnings when build * Apply suggestions from code review Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com> * added the suggestions to make it more exiled like * Moved to Player Handler * Update Scp1576TransmissionEnded.cs Change comments * Expose Buttons property in Door class to access door button variants --------- Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com> Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
Adds to the Door class a array of ButtonVariant
What is the current behavior? (You can also link to an open issue here)
Non existend
What is the new behavior? (if this is a feature change)
You can now use
Door::ButtonsDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other