feat: add setter Usable::IsUsing - #753
Conversation
Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com>
Change comments
|
instead of |
louis1706
left a comment
There was a problem hiding this comment.
looks good for me will still need to test it
|
you can also add StopUsing :3 |
There was a problem hiding this comment.
To keep the transpiler as clean and simple as possible, just take the referencehub and make the event argument a player.get inside the constructor – at least that was Yamato's suggestion for me.
There was a problem hiding this comment.
this was merged some time ago
There was a problem hiding this comment.
oh shit why is it now with this event wtf
There was a problem hiding this comment.
it's because you make your PR from Master initially so it's missed some new addition probably just update branch fix it
|
thanks |
|
or maybe add this to is using property? |
very good idea actually do not even need this method at all if you make it on the IsUsing property |
* Adds a event that is called after player stops talking with 1576 * Simplify initialization of TransmissionEnded event. * should be no more warnings when build * Apply suggestions from code review Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com> * added the suggestions to make it more exiled like * Moved to Player Handler * Update Scp1576TransmissionEnded.cs Change comments * Add `StartUsing` method to force item usage * adds very professional comment * Adds stop using * Refactor `IsUsing` property to include setter and remove redundant usage methods --------- Co-authored-by: @Someone <45270312+Someone-193@users.noreply.github.com> Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>
Description
Describe the changes
Adds
UsableItemsController.ServerEmulateMessagewrapper for usable itemWhat is the current behavior? (You can also link to an open issue here)
Non existend
What is the new behavior? (if this is a feature change)
You can now force the player to start using medkit
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other