Updating backend dev command - #196
Merged
Merged
Conversation
Member
|
Thanks @kyileiaye2021 ! |
JonnyTran
added a commit
that referenced
this pull request
Sep 16, 2026
* ci(server): give the docker build a registry layer cache `cache-from`/`cache-to` were unset, so every CI build refetched the 231 MB lance extension and re-ran both apt layers from scratch. None of the layer ordering in the Dockerfile bought anything on CI. Registry cache rather than `type=gha`: the image is ~1.9 GB, and `mode=max` on it would churn through the 10 GB Actions cache quota. The cache tag follows `SERVER_DOCKER_IMAGE`, so dev and release caches never mix — and neither do their platform sets. `image-manifest=true,oci-mediatypes=true` is what Docker Hub will accept for the cache manifest. PR previews read the cache but do not write it: they push from divergent trees and would only evict trunk's entries. The `latest` push rebuilds the same context, so it reads the cache and does not re-export it. * ci: give GITHUB_TOKEN read-only defaults Adds a top-level `permissions: contents: read` to the three workflows that had none, and moves the write scopes in github-release, extralit.docs and extralit onto the single job that actually needs them. Closes code scanning alerts #176, #196, #252, #253, #313, #314. * ci(server): compute the build env with expressions, not bash The 40-line if/else only ever branched on `inputs`, so it moves to a job-level `env:` block. What's left in shell is IMAGE_TAG, the one value that reads an earlier step's output. Docker Hub creds go straight to the login step instead of through GITHUB_ENV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the development instructions in
README.mdto usepdm run server-devinstead ofpdm run devwhen running the backend server.This aligns the README with the existing project scripts and other documentation, and helps avoid confusion during local development setup.
Related Tickets & Documents
Closes #195
What type of PR is this? (check all applicable)
Steps to QA
Added/updated tests?
have not been included
Added/updated documentations?
have not been included
Checklist