Skip to content

[Wax] Fix flaky unit test - #1023

Merged
PaulBernier merged 1 commit into
FactomProject:FD-1225_wax_rollupfrom
WhoSoup:whosoup-p2p-flaky_unit_test
Aug 20, 2020
Merged

PaulBernier merged 1 commit into
FactomProject:FD-1225_wax_rollupfrom
WhoSoup:whosoup-p2p-flaky_unit_test

Conversation

@WhoSoup

@WhoSoup WhoSoup commented Aug 19, 2020

Copy link
Copy Markdown
Member

Mirror of WhoSoup/factom-p2p#48

In the Test_controller_manageData, one of the tests was routing a peer share, which happens inside a goroutine. A race condition sometimes occurred where the controller was stopped and the unit test checked before the goroutine finished.

@PaulBernier
PaulBernier merged commit bc25cca into FactomProject:FD-1225_wax_rollup Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants