feat(deps): upgrade eslint to v10 across the frontend toolchain by gkorland · Pull Request #697 · FalkorDB/QueryWeaver

gkorland · 2026-08-12T20:49:12Z

Summary

Unblocks Dependabot PR #691 (@eslint/js 9.39.2 → 10.0.1), which cannot pass CI on its own: @eslint/js@10 declares peerOptional eslint@^10.0.0 while the project pins eslint@^9.32.0, so npm ci fails with ERESOLVE in the unit-tests job.

Moving to eslint 10 requires a coordinated bump rather than a single dev-dep update.

Changes

Package	Before	After	Reason
`eslint`	`^9.32.0`	`^10.8.1`	required by `@eslint/js@10`
`@eslint/js`	`^9.32.0`	`^10.0.1`	the bump from #691
`eslint-plugin-react-hooks`	`^5.2.0`	`^7.1.1`	v5 peers on eslint `<=9`

Unchanged because they already declare eslint 10 support:

typescript-eslint@8.66.0 — peers ^8.57.0 || ^9.0.0 || ^10.0.0
eslint-plugin-react-refresh@0.4.20 — peers >=8.40

No flat-config migration was needed: app/eslint.config.cjs does not reference @eslint/js or the React plugins (they are currently unused devDependencies).

Root package-lock.json is regenerated alongside app/, since it embeds the app workspace tree via "queryweaver-app": "file:app" (see #696).

Testing

npm run lint in app/ — clean, zero errors/warnings under eslint 10.8.1
npm run build in app/ — succeeds
npm ci --dry-run — passes at both the repo root and app/ (this is the exact failure mode of chore(deps-dev): bump @eslint/js from 9.39.2 to 10.0.1 in /app #691)

Memory / Performance Impact

N/A — dev tooling only, no runtime dependencies affected.

Related Issues

Supersedes #691.

Summary by CodeRabbit

Chores
- Updated development linting tools to newer versions.
- Improved compatibility with the latest linting and React Hooks validation standards.

Unblocks the @eslint/js 9 -> 10 bump (#691), which alone caused an ERESOLVE failure because @eslint/js@10 peers on eslint@^10 while the project pinned eslint@^9. Coordinated bumps: - eslint ^9.32.0 -> ^10.8.1 - @eslint/js ^9.32.0 -> ^10.0.1 - eslint-plugin-react-hooks ^5.2.0 -> ^7.1.1 (v5 peers on eslint <=9) typescript-eslint 8.66 and eslint-plugin-react-refresh 0.4.20 already declare eslint 10 support, so they are unchanged. Root package-lock.json regenerated as well, since it embeds the app workspace tree via "queryweaver-app": "file:app". Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

overcut-ai · 2026-08-12T20:49:15Z

Completed Working on "Code Review"

✅ Review publication complete: all chunk comments were posted and final review was submitted (COMMENT). Total comments: 2 across 2 files.

✅ Workflow completed successfully.

👉 View complete log

railway-app · 2026-08-12T20:49:24Z

🚅 Deployed to the QueryWeaver-pr-697 environment in queryweaver

Service	Status	Web	Updated (UTC)
QueryWeaver	✅ Success (View Logs)	Web	Aug 12, 2026 at 8:50 pm

coderabbitai · 2026-08-12T20:49:29Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 398ccf14-e82f-4d16-a13f-e1df8ac3efae

📥 Commits

Reviewing files that changed from the base of the PR and between b636d65 and 145dbc5.

⛔ Files ignored due to path filters (2)

app/package-lock.json is excluded by !**/package-lock.json
package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (1)

app/package.json

📝 Walkthrough

Walkthrough

The pull request upgrades ESLint tooling in app/package.json. It updates @eslint/js and eslint to version 10.x and eslint-plugin-react-hooks to version 7.x.

Changes

Development tooling

Layer / File(s)	Summary
Linting dependency upgrades `app/package.json`	Upgrades `@eslint/js` and `eslint` to 10.x, and `eslint-plugin-react-hooks` to 7.x.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: barakb, copilot, galshubeli

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: upgrading ESLint to v10 across the frontend toolchain.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/eslint-10-upgrade

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T20:49:32Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
✅ 0 package(s) with unknown licenses.
⚠️ 4 packages with OpenSSF Scorecard issues.

View full job summary

overcut-ai

Thanks for the dependency upgrade work — I reviewed the posted findings and there are 2 MAJOR comments across 2 files (app/package.json, package-lock.json).

Key themes

Environment compatibility risk: The ESLint 10 upgrade introduces a stricter Node engine floor that may break installs/lint in older CI/local environments.
Lockfile maintainability/determinism: Root lockfile regeneration appears to include broad app transitive churn beyond the intended scoped dependency updates.

Recommended next steps

Align CI/docs/runtime tooling baseline to the Node version required by the upgraded ESLint stack (or adjust versions to match current baseline).
Re-generate and narrow lockfile changes to only intended workspace-scoped deltas to reduce future drift/churn.
Re-run install/lint checks in the target CI Node environment after lockfile cleanup to confirm stability.

overcut-ai · 2026-08-12T20:51:16Z

    "autoprefixer": "^10.4.27",
-    "eslint": "^9.32.0",
-    "eslint-plugin-react-hooks": "^5.2.0",
+    "eslint": "^10.8.1",


[major]: This bump moves lint tooling to eslint@10, whose engine requirement is ^20.19.0 || ^22.13.0 || >=24; environments on Node 18 or early Node 20 will fail install/lint after this change.

overcut-ai · 2026-08-12T20:51:17Z

        "node": ">=6.9.0"
      }
    },
+    "app/node_modules/@eslint/config-array": {


[major]: The root lockfile now includes a large set of app-scoped entries (app/node_modules/*) plus many unrelated transitive changes (e.g. browserslist toolchain), which makes workspace installs less deterministic across npm versions and creates high churn unrelated to the ESLint bump. This can cause CI/local lockfile drift on future npm install runs.

gkorland mentioned this pull request Aug 12, 2026

chore(deps-dev): bump @eslint/js from 9.39.2 to 10.0.1 in /app #691

Closed

railway-app Bot temporarily deployed to queryweaver / QueryWeaver-pr-697 August 12, 2026 20:49 Destroyed

overcut-ai Bot reviewed Aug 12, 2026

View reviewed changes

gkorland merged commit 067515c into staging Aug 12, 2026
14 checks passed

gkorland deleted the feat/eslint-10-upgrade branch August 12, 2026 20:56

Navigation Menu

Uh oh!

feat(deps): upgrade eslint to v10 across the frontend toolchain - #697

feat(deps): upgrade eslint to v10 across the frontend toolchain#697
gkorland merged 1 commit into
stagingfrom
feat/eslint-10-upgrade

gkorland commented Aug 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

overcut-ai Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

railway-app Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 12, 2026

Uh oh!

overcut-ai Bot left a comment

Uh oh!

overcut-ai Bot Aug 12, 2026

Uh oh!

overcut-ai Bot Aug 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

gkorland commented Aug 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Testing

Memory / Performance Impact

Related Issues

Summary by CodeRabbit

Uh oh!

overcut-ai Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Completed Working on "Code Review"

Uh oh!

railway-app Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 12, 2026

Dependency Review

Uh oh!

overcut-ai Bot left a comment

Choose a reason for hiding this comment

Key themes

Recommended next steps

Uh oh!

overcut-ai Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

overcut-ai Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gkorland commented Aug 12, 2026 •

edited by coderabbitai Bot

Loading

overcut-ai Bot commented Aug 12, 2026 •

edited

Loading

railway-app Bot commented Aug 12, 2026 •

edited

Loading

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading