Replace SpellList with TreeList in ListIota - #1032
Merged
Merged
Conversation
s5bug
marked this pull request as ready for review
May 6, 2026 08:13
s5bug
marked this pull request as draft
June 7, 2026 21:32
s5bug
marked this pull request as ready for review
June 11, 2026 19:25
s5bug
force-pushed
the
vector-fixes-3
branch
3 times, most recently
from
June 12, 2026 01:59
260cf3a to
40ccf3c
Compare
Robotgiggle
approved these changes
Jul 15, 2026
Member
There was a problem hiding this comment.
Nit: the changes to this file seem to be unnecessary
Contributor
Author
There was a problem hiding this comment.
Huh: they're probably a remnant of a future PR that got split.
Contributor
Author
There was a problem hiding this comment.
@Robotgiggle I don't have a good PC right now: would you be willing to rebase -i and edit the commit that makes these changes to remove them, and force-push to my branch?
Robotgiggle
force-pushed
the
vector-fixes-3
branch
from
July 15, 2026 02:27
40ccf3c to
746d308
Compare
Robotgiggle
enabled auto-merge
July 15, 2026 02:33
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 15, 2026
s5bug
added a commit
to s5bug/HexMod
that referenced
this pull request
Jul 17, 2026
…gColors#1033) Stacked on FallingColors#1032 TODO is make a pass through _all_ the list ops and make sure they're not doing O(n) copies but I'm not going to waste my time with that in case I have to go back and modify other stuff --------- Co-authored-by: Robotgiggle <88736742+Robotgiggle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.