Main to next - #1159
Merged
Merged
Conversation
…#1115) Fixes FallingColors#505 The behavior of Assessor's Purification: - Item frame with focus - True (correct. before and after PR) - Wall scroll entity - False (correct. before and after PR, though for different reasons) - Item frame with scroll - False (incorrect. before) and True (correct. after PR)
…lingColors#1080) Fixes FallingColors#964. Also moves the `cannot_modify_cost` tag jsons from `src/generated/data` to `src/main/data` to stop them from being deleted by the datagen process. If there's some way to tell the datagen system to create an action tag with no entries, that would be a much better solution - please let me know if that's possible.
Robotgiggle
approved these changes
Jul 27, 2026
Robotgiggle
left a comment
Member
There was a problem hiding this comment.
LGTM! #1080 was indeed done correctly. The rename in the original PR was because the original version of the file would get deleted whenever datagen ran. At some point, somebody must have run datagen on the 1.21 branch and committed the result, removing the original file.
Member
|
(Also, sorry for taking so long to get to this) |
Merged
via the queue into
FallingColors:1.21
with commit Jul 27, 2026
2b336a7
13 of 16 checks passed
Robotgiggle
added a commit
to s5bug/HexMod
that referenced
this pull request
Jul 28, 2026
This reverts commit 2b336a7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes PRs:
I'm not sure if I handled #1080 correctly. On this branch it becomes an addition rather than a rename.