Skip to content

Fix mining tier check for Break Block, add hex_unbreakable tag - #1186

Merged
IridescentVoid merged 4 commits into
1.21from
tier-fix
Jul 8, 2026
Merged

Fix mining tier check for Break Block, add hex_unbreakable tag#1186
IridescentVoid merged 4 commits into
1.21from
tier-fix

Conversation

@Robotgiggle

Copy link
Copy Markdown
Member

Implements a much simpler method for checking whether a given block is breakable by a given tier, and moves the function itself out of the xplat system and into HexUtils. Also, adds an empty tag json for hex_unbreakable, which was referenced in the previous tier checking system but not actually implemented.

@IridescentVoid IridescentVoid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Checks performed:

  • Code looks logically sound.
  • Compiles and runs fine.
  • Break Block attempted on:
    • Bedrock - failure (silent) as expected
    • Sandstone - success as expected
    • With the following tag change:
      • add(tag(HexTags.Blocks.HEX_UNBREAKABLE), HexBlocks.EDIFIED_PLANKS); (placed in HexBlockTagProvider.addTags and ran datagen)
      • Edified Planks - failure (silent) as expected
    • With the following tag change:
      • add(tag(BlockTags.INCORRECT_FOR_DIAMOND_TOOL), HexBlocks.EDIFIED_PLANKS);
      • Edified Planks - failure (silent) as expected
      • Sandstone - success as expected

@IridescentVoid
IridescentVoid added this pull request to the merge queue Jul 8, 2026
Merged via the queue into 1.21 with commit c3a6089 Jul 8, 2026
6 of 9 checks passed
@github-project-automation github-project-automation Bot moved this from 📋 Backlog to ✅ Done in Hex Casting Jul 8, 2026
@Robotgiggle
Robotgiggle deleted the tier-fix branch July 30, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants