Main to next - #1216
Merged
Merged
Conversation
…#1115) Fixes FallingColors#505 The behavior of Assessor's Purification: - Item frame with focus - True (correct. before and after PR) - Wall scroll entity - False (correct. before and after PR, though for different reasons) - Item frame with scroll - False (incorrect. before) and True (correct. after PR)
…lingColors#1080) Fixes FallingColors#964. Also moves the `cannot_modify_cost` tag jsons from `src/generated/data` to `src/main/data` to stop them from being deleted by the datagen process. If there's some way to tell the datagen system to create an action tag with no entries, that would be a much better solution - please let me know if that's possible.
Adds Contemplation, a variant of Consideration that has no draw-time effect (and thus does not require double-escaping). Signature is 0.11.3 consideration but drawn in reverse. Closes FallingColors#1092 --------- Co-authored-by: Robotgiggle <88736742+Robotgiggle@users.noreply.github.com>
This fixes the intermittent build failures caused by https://maven.terraformersmc.com/releases sometimes returning the following error: ``` Premature end of chunk coded message body: closing chunk expected ``` The new maven is a mirror run by a Terraformers team member.
Closes FallingColors#1200 This is how it looks in IJ: <img width="1037" height="335" alt="{D55CE6B8-A345-48EE-AA61-3C0463DE6D05}" src="https://github.com/user-attachments/assets/3063d098-9105-4a50-a9d6-cdea471f1a64" /> Not pretty, but not outright horrible...
Closes FallingColors#901 All the classes removed are unused in code and have been replaced by Arithmetic implementations.
Robotgiggle
approved these changes
Jul 28, 2026
Robotgiggle
left a comment
Member
There was a problem hiding this comment.
Looks good, but I can't merge this myself since it needs to not be squashed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes PRs:
Someone more familiar with the datagen than me needs to check why
scroll_paper.jsonisn't being generated under theCommon/orNeoforge/generated resources.runAllDatagenshould probably completely delete the generated resources directory before running just so stuff like this can be caught at the right time.