Main to next (part 1) - #1262
Merged
Merged
Conversation
…allingColors#1218) On Fabric, the check for "is Break Block able to break this" uses a list of tools and checks whether any of them are valid for the target block. However, cobwebs are broken using a sword, and that wasn't included in the list, which caused Break Block to be unable to break them. This PR fixes that.
adds `visit` and `visitChildren` to iotas letting you apply a UnaryOperator to an entire tree of them. this is like hexal's IMappableIota except I don't know if that does self pre or post (or if it does self at all). awa. I haven't tested this in prod; hex doesn't have anything that would use this yet. @IridescentVoid I believe you have a patch that may want to use this? Cc: @IridescentVoid Change-Id: Ic464f4702ba9b0379c93e31723e2a5fe6a6a6964 Issue: closes FallingColors#1083 Prereq: FallingColors#1195
Includes entries for: - FallingColors#1191
Adds a list in the config that can be used to rescale the cost of any action. Entries consist of a resource location and a number (ie `hexcasting:explode 2.5`) and the cost of the listed action is scaled by the listed number. Also adds a config value with a global scaling factor that will apply to _all_ media costs, if you just want to apply an overall buff or nerf to hex in your pack/server. Both of these scaling factors apply before the `media_consumption_modifier` attribute. The global scaling factor is not applied to anything in the `cannot_modify_cost` tag, so that making everything cheaper doesn't immediately introduce a bunch of exploits. However, entries in the per-action list for actions in that tag _do_ still work, in case for whatever reason you actually do want to rescale one of those patterns.
When I turned the escaper patterns into `Action`s in FallingColors#1047 I forgot that `Action` doesn't automatically handle incrementing the op count. This PR fixes that by manually incrementing it, just like in all the other patterns that directly extend `Action`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This must not be squash-merged!!!
Includes PRs: