Fix Media Phial consumption priority on Forge - #526
Merged
Conversation
Priority on non-static media holder items was incorrectly hardcoded to 40 instead of the ADMediaHolder constant, 4000, so phials were being targeted last instead of first.
SamsTheNerd
reviewed
Nov 16, 2023
SamsTheNerd
left a comment
Member
There was a problem hiding this comment.
seems like it will fix the issue on forge, however it still hardcodes it so that all phial-like items will have the same priority. This may be a good opportunity to expose getConsumptionPriority() as a part of MediaHolderItem, so that addons can more easily change the priority of phial-like items. Ideally it'd be defaulted to ADMediaHolder.BATTERY_PRIORITY so that we don't break existing items.
@object-Object up to you if you want to merge this in for the fix. I can do the API changes once I'm home and have some time to set up the hex repo locally.
Member
|
let's do it separately. thanks for the PR @artynova! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Priority on non-static media holder items was incorrectly hardcoded to 40 instead of the ADMediaHolder constant, 4000, so phials were being targeted last instead of first.